Fix CodeMirror to not unconditionally try to use the 2006 toolbar (as that's being deleted)
Closed, ResolvedPublic1 Estimated Story Points
Actions

Details

	Subject	Repo	Branch	Lines +/-
	Remove support for classic toolbar (mediawiki.toolbar)	mediawiki/extensions/CodeMirror	master	+14 -169
	Expect that deprecated mediawiki.toolbar may not be available	mediawiki/extensions/CodeMirror	master	+12 -6

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T31145 Core features that shouldn't be in core (tracking)
Declined	None	T46915 EditPage.php assumes mediawiki.action.edit module present (breaks mobile)
Resolved	Jdforrester-WMF	T19653 Classic edit toolbar & edit tools (tracking)
Resolved	Jdforrester-WMF	T30856 Remove classic edit toolbar from core
Resolved	Esanders	T177098 Fix CodeMirror to not unconditionally try to use the 2006 toolbar (as that's being deleted)

Event Timeline

Jdforrester-WMF created this task.Sep 29 2017, 4:16 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 29 2017, 4:17 PM

Specifically https://github.com/wikimedia/mediawiki-extensions-CodeMirror/blob/3f226d7223ef7734dcf22a192dd926840b22a125/resources/ext.CodeMirror.js#L503

• Elitre subscribed.Oct 2 2017, 10:02 AM

Niharika lowered the priority of this task from Medium to Low.Nov 7 2017, 11:23 PM

Restricted Application added a project: Community-Tech. · View Herald TranscriptNov 7 2017, 11:23 PM

• Whatamidoing-WMF mentioned this in T30856: Remove classic edit toolbar from core.Nov 27 2017, 6:39 PM

• Elitre mentioned this in T163929: Support the Editing team in their changes to classic edit toolbar.Dec 6 2017, 11:36 AM

Change 402032 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/CodeMirror@master] Expect that deprecated mediawiki.toolbar may not be available

https://gerrit.wikimedia.org/r/402032

gerritbot added a project: Patch-For-Review.Jan 4 2018, 12:36 PM

Change 402036 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/CodeMirror@master] Remove support for classic toolbar (mediawiki.toolbar)

https://gerrit.wikimedia.org/r/402036

Jdforrester-WMF closed this task as Resolved.Jan 4 2018, 4:17 PM

Jdforrester-WMF assigned this task to Esanders.

Jdforrester-WMF removed a project: Patch-For-Review.

Jdforrester-WMF set the point value for this task to 1.

Change 402032 merged by jenkins-bot:
[mediawiki/extensions/CodeMirror@master] Expect that deprecated mediawiki.toolbar may not be available

https://gerrit.wikimedia.org/r/402032

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)).Jan 4 2018, 5:00 PM

kaldari moved this task from New & TBD Tickets to Archive on the Community-Tech board.Jan 17 2018, 1:19 AM

Liuxinyu970226 moved this task from Backlog to Done on the MediaWiki-extensions-CodeMirror board.Feb 2 2018, 2:19 PM

Change 402036 abandoned by Esanders:
Remove support for classic toolbar (mediawiki.toolbar)

Reason:
Replaced by Ib8d104ddf104cfeeee1fc7a055293a03fe8e2d3d