Page MenuHomePhabricator
Create Task
Maniphest T175566

Check “single value” and “multi value” constraints on qualifiers and references
Closed, ResolvedPublic
Actions

Description

This seems pretty straightforward, it’s just the implementation that’s slightly tricky. If we go with the “sibling snaks” solution (or whatever we call it) in T175562 and T175565, we can also use that for these constraint types (just count the sibling snaks).

Patch-For-Review:

Details

SubjectRepoBranchLines +/-
Remove not needed Statements from Multi/SingleValueChecker testsmediawiki/extensions/WikibaseQualityConstraintsmaster+2 -6
Support qualifier and reference in value count checkersmediawiki/extensions/WikibaseQualityConstraintsmaster+70 -6
Rewrite ValueCountCheckerHelpermediawiki/extensions/WikibaseQualityConstraintsmaster+44 -50
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lucas_Werkmeister_WMDE created this task.Sep 11 2017, 1:39 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 11 2017, 1:39 PM
Lucas_Werkmeister_WMDE mentioned this in T175570: Don’t check some constraint types on non-statement contexts.Sep 11 2017, 1:46 PM
Lydia_Pintscher moved this task from incoming to consider for next sprint on the Wikidata board.Jan 15 2018, 4:22 PM
Lucas_Werkmeister_WMDE added a project: Wikidata-Sprint-2018-01-17.Jan 16 2018, 2:42 PM
Lucas_Werkmeister_WMDE claimed this task.Jan 18 2018, 11:16 AM
Lucas_Werkmeister_WMDE moved this task from Backlog to In Progress on the Wikidata-Sprint-2018-01-17 board.
Lucas_Werkmeister_WMDE mentioned this in T185209: Introduce “sibling snaks” abstraction.Jan 18 2018, 12:39 PM
gerritbot subscribed.Jan 18 2018, 6:19 PM

Change 405033 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Rewrite ValueCountCheckerHelper

https://gerrit.wikimedia.org/r/405033

gerritbot added a project: Patch-For-Review.Jan 18 2018, 6:19 PM
gerritbot added a comment.Jan 19 2018, 12:43 PM

Change 405282 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Support qualifier and reference in value count checkers

https://gerrit.wikimedia.org/r/405282

Lucas_Werkmeister_WMDE moved this task from In Progress to Review on the Wikidata-Sprint-2018-01-17 board.Jan 19 2018, 12:43 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
gerritbot added a comment.Jan 23 2018, 1:51 PM

Change 405875 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Remove not needed Statements from Multi/SingleValueChecker tests

https://gerrit.wikimedia.org/r/405875

Lucas_Werkmeister_WMDE moved this task from Review to Done on the Wikidata-Sprint-2018-01-17 board.Jan 23 2018, 3:33 PM
Lucas_Werkmeister_WMDE closed subtask T185209: Introduce “sibling snaks” abstraction as Resolved.
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
gerritbot added a comment.Jan 23 2018, 3:40 PM

Change 405033 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Rewrite ValueCountCheckerHelper

https://gerrit.wikimedia.org/r/405033

gerritbot added a comment.Jan 23 2018, 3:40 PM

Change 405282 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Support qualifier and reference in value count checkers

https://gerrit.wikimedia.org/r/405282

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)).Jan 23 2018, 4:00 PM
Lucas_Werkmeister_WMDE closed this task as Resolved.Jan 23 2018, 5:26 PM
gerritbot added a comment.Jan 25 2018, 3:22 PM

Change 405875 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Remove not needed Statements from Multi/SingleValueChecker tests

https://gerrit.wikimedia.org/r/405875

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits