Page MenuHomePhabricator
Create Task
Maniphest T171848

Port Echo Selenium tests from Ruby to Node.js
Closed, ResolvedPublic
Actions

Description

Done

👍 368409 (mediawiki/extensions/Echo): Selenium test: alerts and notices are visible after logging in
🤙 368410 (integration/config): Run mediawiki-core-qunit-selenium-jessie for Echo
⚰️ 391249 (integration/config): Run qunit-selenium for Echo
🤟 399131 (mediawiki/extensions/Echo): Remove Ruby browser tests
🖖 399209 (integration/config): Do not run selenium-Echo Jenkins job daily
👋 403640 (mediawiki/extensions/Echo): ESLint parserOptions is reduntand when es6 env is used
👋☝️403646 (integration/config): Run qunit-selenium job for Echo
🚀 439615 (mediawiki/extensions/Echo): Make it possible to run Selenium tests from Echo folder
✈️ 439617 (mediawiki/extensions/Echo): Use new page objects from mediawiki/core in Selenium tests

Details

SubjectRepoBranchLines +/-
Use new page objects from mediawiki/core in Selenium testsmediawiki/extensions/Echomaster+2 -2
selenium: Make it possible to run tests from Echo foldermediawiki/extensions/Echomaster+100 -4
Run qunit-selenium job for Echointegration/configmaster+1 -2
ESLint parserOptions is reduntand when es6 env is usedmediawiki/extensions/Echomaster+0 -3
Selenium test: alerts and notices are visible after logging inmediawiki/extensions/Echomaster+70 -0
Remove Ruby browser testsmediawiki/extensions/Echomaster+14 -391
Do not run selenium-Echo Jenkins job dailyintegration/configmaster+0 -8
Run qunit-selenium for Echointegration/configmaster+1 -2
Run mediawiki-core-qunit-selenium-jessie for Echointegration/configmaster+1 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Restricted Application added projects: Collaboration-Team-Triage, Release-Engineering-Team (Kanban). · View Herald TranscriptJul 27 2017, 2:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
zeljkofilipin moved this task from Backlog 🪒 to Q1 👔 on the User-zeljkofilipin board.Jul 27 2017, 2:04 PM
zeljkofilipin moved this task from Inbox to Node.js on the Browser-Tests-Infrastructure board.
zeljkofilipin mentioned this in T139740: Port Selenium tests from Ruby to Node.js.
gerritbot subscribed.Jul 28 2017, 12:05 PM

Change 368409 had a related patch set uploaded (by Zfilipin; owner: Zfilipin):
[mediawiki/extensions/Echo@master] WIP WebdriverIO test

https://gerrit.wikimedia.org/r/368409

gerritbot added a project: Patch-For-Review.Jul 28 2017, 12:05 PM
gerritbot added a comment.Jul 28 2017, 12:09 PM

Change 368410 had a related patch set uploaded (by Zfilipin; owner: Zfilipin):
[integration/config@master] Run mediawiki-core-qunit-selenium-jessie for Echo

https://gerrit.wikimedia.org/r/368410

gerritbot added a comment.Jul 28 2017, 12:17 PM

Change 368410 merged by jenkins-bot:
[integration/config@master] Run mediawiki-core-qunit-selenium-jessie for Echo

https://gerrit.wikimedia.org/r/368410

zeljkofilipin added a comment.Jul 28 2017, 1:08 PM

Green! https://integration.wikimedia.org/ci/job/mediawiki-core-qunit-selenium-jessie/4642/console

zeljkofilipin reassigned this task from zeljkofilipin to Etonkovidova.Jul 28 2017, 1:09 PM
zeljkofilipin moved this task from Backlog to Done (within RelEng) on the Release-Engineering-Team (Kanban) board.
zeljkofilipin moved this task from Q1 👔 to Deep work 🌊 on the User-zeljkofilipin board.
zeljkofilipin moved this task from Deep work 🌊 to Watching 📺 on the User-zeljkofilipin board.
Catrope removed projects: Notifications, Collaboration-Team-Triage.Aug 1 2017, 5:48 PM
zeljkofilipin merged a task: T174592: Echo: Migrate browser tests from Ruby to node.js.Aug 31 2017, 2:50 PM
zeljkofilipin added a subscriber: • Mattflaschen-WMF.
zeljkofilipin removed projects: Patch-For-Review, Browser-Tests-Infrastructure, JavaScript, Ruby.Nov 2 2017, 5:40 PM
zeljkofilipin added a project: Collaboration-Team-Triage.Nov 10 2017, 3:18 PM
zeljkofilipin edited parent tasks, added: T174594: Global Collaboration: Migrate browser tests from Ruby to node.js; removed: T139740: Port Selenium tests from Ruby to Node.js.
zeljkofilipin added a subscriber: SBisson.Nov 14 2017, 1:37 PM

@SBisson: @Etonkovidova and I are pairing on this. Let me know if you need help. I am available for pairing and/or code review. Documentation is available: Selenium/Node.js, Selenium/Node.js/Write...

zeljkofilipin claimed this task.Nov 14 2017, 3:37 PM
zeljkofilipin lowered the priority of this task from High to Medium.
zeljkofilipin moved this task from Watching 📺 to Deep work 🌊 on the User-zeljkofilipin board.
zeljkofilipin moved this task from Done (within RelEng) to In-progress on the Release-Engineering-Team (Kanban) board.
zeljkofilipin reassigned this task from zeljkofilipin to Etonkovidova.Nov 14 2017, 4:33 PM
zeljkofilipin moved this task from In-progress to Done (within RelEng) on the Release-Engineering-Team (Kanban) board.
zeljkofilipin moved this task from Deep work 🌊 to Watching 📺 on the User-zeljkofilipin board.
gerritbot added a comment.Nov 14 2017, 5:14 PM

Change 391249 had a related patch set uploaded (by Zfilipin; owner: Zfilipin):
[integration/config@master] Run qunit-selenium for Echo

https://gerrit.wikimedia.org/r/391249

gerritbot added a project: Patch-For-Review.Nov 14 2017, 5:14 PM
gerritbot added a comment.Dec 19 2017, 2:40 AM

Change 399131 had a related patch set uploaded (by Mattflaschen; owner: Mattflaschen):
[mediawiki/extensions/Echo@master] Remove Ruby browser tests

https://gerrit.wikimedia.org/r/399131

• Mattflaschen-WMF added a comment.Dec 19 2017, 2:50 AM

@Etonkovidova @zeljkofilipin Were you working on this, or should we just go ahead and remove them per the meeting?

gerritbot added a comment.Dec 19 2017, 3:05 PM

Change 368409 abandoned by Zfilipin:
Selenium test: alerts and notices are visible after logging in

Reason:
just an exercise

https://gerrit.wikimedia.org/r/368409

gerritbot added a comment.Dec 19 2017, 3:06 PM

Change 391249 abandoned by Zfilipin:
Run qunit-selenium for Echo

https://gerrit.wikimedia.org/r/391249

zeljkofilipin added a comment.Dec 19 2017, 3:12 PM

@Mattflaschen-WMF go ahead and delete the tests. @Etonkovidova and I were just trying out Selenium for Echo. I have abandoned the patch.

zeljkofilipin moved this task from Watching 📺 to Deep work 🌊 on the User-zeljkofilipin board.Dec 19 2017, 4:06 PM
gerritbot added a comment.Dec 19 2017, 4:13 PM

Change 399209 had a related patch set uploaded (by Zfilipin; owner: Zfilipin):
[integration/config@master] Do not run selenium-Echo Jenkins job daily

https://gerrit.wikimedia.org/r/399209

gerritbot added a comment.Dec 19 2017, 4:20 PM

Change 399209 merged by jenkins-bot:
[integration/config@master] Do not run selenium-Echo Jenkins job daily

https://gerrit.wikimedia.org/r/399209

zeljkofilipin renamed this task from Port Echo Selenium tests from Ruby to Node.js to Delete Echo Selenium tests.Dec 20 2017, 11:12 AM
zeljkofilipin claimed this task.
zeljkofilipin lowered the priority of this task from Medium to Low.
zeljkofilipin moved this task from Done (within RelEng) to In-progress on the Release-Engineering-Team (Kanban) board.
• Mattflaschen-WMF added a comment.Dec 21 2017, 8:01 PM
In T171848#3848321, @zeljkofilipin wrote:

@Mattflaschen-WMF go ahead and delete the tests. @Etonkovidova and I were just trying out Selenium for Echo. I have abandoned the patch.

Done (patch is now up and restored).

Feel free to finish/review/merge the node.js one too. It seems useful.

gerritbot added a comment.Dec 22 2017, 11:54 AM

Change 399131 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Remove Ruby browser tests

https://gerrit.wikimedia.org/r/399131

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)).Dec 22 2017, 12:00 PM
gerritbot added a comment.Dec 22 2017, 12:43 PM

Change 368409 restored by Zfilipin:
Selenium test: alerts and notices are visible after logging in

Reason:
Per T171848#3855278

https://gerrit.wikimedia.org/r/368409

zeljkofilipin renamed this task from Delete Echo Selenium tests to Port Echo Selenium tests from Ruby to Node.js.Dec 22 2017, 12:43 PM
zeljkofilipin reassigned this task from zeljkofilipin to Etonkovidova.
zeljkofilipin raised the priority of this task from Low to Medium.
zeljkofilipin removed projects: User-zeljkofilipin, Release-Engineering-Team (Kanban).
gerritbot added a comment.Jan 5 2018, 5:07 PM

Change 368409 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Selenium test: alerts and notices are visible after logging in

https://gerrit.wikimedia.org/r/368409

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)); removed MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)).Jan 5 2018, 6:01 PM
zeljkofilipin added a project: User-zeljkofilipin.Jan 8 2018, 4:21 PM
gerritbot added a comment.Jan 11 2018, 1:03 PM

Change 403640 had a related patch set uploaded (by Zfilipin; owner: Zfilipin):
[mediawiki/extensions/Echo@master] ESLint parserOptions is reduntand when es6 env is used

https://gerrit.wikimedia.org/r/403640

gerritbot added a comment.Jan 11 2018, 1:31 PM

Change 403646 had a related patch set uploaded (by Zfilipin; owner: Zfilipin):
[integration/config@master] Run qunit-selenium job for Echo

https://gerrit.wikimedia.org/r/403646

gerritbot added a comment.Jan 11 2018, 10:45 PM

Change 403640 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] ESLint parserOptions is reduntand when es6 env is used

https://gerrit.wikimedia.org/r/403640

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-01-16 (1.31.0-wmf.17)); removed MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)).Jan 13 2018, 8:01 PM
gerritbot added a comment.Jan 15 2018, 5:22 PM

Change 403646 merged by jenkins-bot:
[integration/config@master] Run qunit-selenium job for Echo

https://gerrit.wikimedia.org/r/403646

• jmatazzoni moved this task from Untriaged to Old Untriaged on the Collaboration-Team-Triage board.Jan 17 2018, 10:53 PM
zeljkofilipin moved this task from Deep work 🌊 to Watching 📺 on the User-zeljkofilipin board.Feb 20 2018, 3:49 PM
gerritbot added a comment.Mar 12 2018, 3:57 PM

Change 418940 had a related patch set uploaded (by Etonkovidova; owner: Etonkovidova):
[mediawiki/extensions/Echo@master] WIP Alerts popup is visible after clicking the icon

https://gerrit.wikimedia.org/r/418940

gerritbot added a comment.Mar 13 2018, 4:41 AM

Change 418940 abandoned by Etonkovidova:
WIP Alerts popup is visible after clicking the icon

Reason:
It breaks the build. Will fix it later.

https://gerrit.wikimedia.org/r/418940

gerritbot added a comment.Mar 19 2018, 3:43 PM

Change 418940 restored by Etonkovidova:
WIP Alerts popup is visible after clicking the icon

Reason:
testing fix

https://gerrit.wikimedia.org/r/418940

zeljkofilipin moved this task from Watching 📺 to Deep work 🌊 on the User-zeljkofilipin board.Mar 19 2018, 4:18 PM
zeljkofilipin moved this task from Deep work 🌊 to Q1 👔 on the User-zeljkofilipin board.May 18 2018, 1:09 PM
zeljkofilipin moved this task from Q1 👔 to Deep work 🌊 on the User-zeljkofilipin board.May 29 2018, 10:25 AM
zeljkofilipin moved this task from Deep work 🌊 to Q1 👔 on the User-zeljkofilipin board.
gerritbot added a comment.Jun 11 2018, 3:51 PM

Change 439615 had a related patch set uploaded (by Zfilipin; owner: Zfilipin):
[mediawiki/extensions/Echo@master] Make it possible to run Selenium tests from Echo folder

https://gerrit.wikimedia.org/r/439615

gerritbot added a comment.Jun 11 2018, 3:57 PM

Change 439617 had a related patch set uploaded (by Zfilipin; owner: Zfilipin):
[mediawiki/extensions/Echo@master] Use new page objects from mediawiki/core in Selenium tests

https://gerrit.wikimedia.org/r/439617

zeljkofilipin moved this task from Q1 👔 to Deep work 🌊 on the User-zeljkofilipin board.Jun 12 2018, 9:00 AM
zeljkofilipin updated the task description. (Show Details)Jun 15 2018, 1:13 PM
zeljkofilipin updated the task description. (Show Details)Jun 15 2018, 1:15 PM
zeljkofilipin updated the task description. (Show Details)Jun 15 2018, 1:20 PM
zeljkofilipin lowered the priority of this task from Medium to Low.Jun 15 2018, 1:25 PM
zeljkofilipin updated the task description. (Show Details)
zeljkofilipin updated the task description. (Show Details)Jun 15 2018, 1:34 PM
zeljkofilipin updated the task description. (Show Details)Jun 15 2018, 1:37 PM
zeljkofilipin moved this task from Deep work 🌊 to Waiting 🏹 on the User-zeljkofilipin board.Jun 20 2018, 1:56 PM
gerritbot added a comment.Jun 22 2018, 2:34 PM

Change 439615 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] selenium: Make it possible to run tests from Echo folder

https://gerrit.wikimedia.org/r/439615

zeljkofilipin updated the task description. (Show Details)Jun 22 2018, 2:53 PM
gerritbot added a comment.Jun 22 2018, 3:36 PM

Change 439617 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Use new page objects from mediawiki/core in Selenium tests

https://gerrit.wikimedia.org/r/439617

zeljkofilipin updated the task description. (Show Details)Jun 25 2018, 3:44 PM
zeljkofilipin closed this task as Resolved.Jun 25 2018, 3:54 PM
zeljkofilipin removed a project: Patch-For-Review.
zeljkofilipin updated the task description. (Show Details)

There are no Ruby Selenium tests in Echo, so the only existing Node.js Selenium test actually resolves this task. More tests could be added later, but it is out of scope of this task.

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)).Jun 30 2018, 3:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits