Maniphest T170999

AceEditor doesn't understand media queries
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Jul 18 2017, 10:27 PM

Tags

Referenced Files

None

Subscribers

Description

Discovered when playing with TemplateStyles...

https://www.mediawiki.org/w/index.php?title=Template:Wikimedia_engineering_project_information/core/styles.css&action=edit shows Error: Expected IDENT at line 1, col 17. but this is perfectly valid CSS.

Details

	Subject	Repo	Branch	Lines +/-
	Update ace to 06.08.2017	mediawiki/extensions/CodeEditor	master	+12 K -28 K

Customize query in gerrit

Related Objects

Mentioned Here: T50826: CodeEditor: Migrate from Ace to CodeMirror

Event Timeline

Jdlrobson created this task.Jul 18 2017, 10:27 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 18 2017, 10:27 PM

Tgr subscribed.Jul 19 2017, 12:03 AM

This is an upstream issue with Ace.

• Esanders removed a project: VisualEditor.Jul 19 2017, 11:50 AM

Ace hasn't been updated in our repo's for a while, and thus the syntax libraries haven't either. Newer versions likely have this fixed.

Ace 1.2.8 does support media queries.
Although AFAIK the plan is to move away from Ace anyway (T50826).

See also: https://gerrit.wikimedia.org/r/#/c/304044/

It confused me when using TemplateStyles so I'm sure it would confuse others and I really want to encourage media queries!!

Several options:

Not to use Ace on that wiki
Not use Ace on css files
Upgrade Ace

What's better?

It's not actually a version issue, we use 1.2.3 and media query support was added way back before 1.0.0. And the bug can be reproduced in the current editor.

Filed ajaxorg/ace#3356.

Anomie edited projects, added CodeEditor; removed TemplateStyles.Jul 20 2017, 2:53 PM

TheDJ moved this task from Backlog to Up next on the CodeEditor board.Aug 6 2017, 2:12 PM

Change 304044 had a related patch set uploaded (by TheDJ; owner: Paladox):
[mediawiki/extensions/CodeEditor@master] Update ace to 06.08.2017

https://gerrit.wikimedia.org/r/304044

gerritbot added a project: Patch-For-Review.Aug 7 2017, 12:08 AM

Jdforrester-WMF closed this task as Resolved.Aug 9 2017, 3:51 PM

Jdforrester-WMF assigned this task to Paladox.

Change 304044 merged by jenkins-bot:
[mediawiki/extensions/CodeEditor@master] Update ace to 06.08.2017

https://gerrit.wikimedia.org/r/304044

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-08-15 (1.30.0-wmf.14)).Aug 9 2017, 4:00 PM