Page MenuHomePhabricator
Create Task
Maniphest T140760

[Task] Create mediainfo entity on demand when adding a statement the first time
Closed, ResolvedPublic
Actions

Description

This ticket is about creating a mediainfo entity on demand when adding a statement for the first time. A related task is T134259 which is about creating a mediainfo entity on demand when hitting save the first time after adding labels, descriptions and/or aliases.

Discussed with @daniel. Possible task breakdown:

  • Refactor EntitySavingHelper:
    • Simple refactoring (without introducing new functionality) of EntityLoading and SavingHelper to EntitySavingHelper extends EntityLoadingHelper. Or use composition so that the SavingHelper gets a LoadingHelper.
    • Add new features to Loading and SavingHelper to support auto-creation of entities.
  • Support editing non-existing MediaInfo entities via SetClaim API module
    • Support auto-creation and the new parameter in all API modules that are not based on ModifyEntity.
    • Possibly discuss if the new parameter really should be supported by all API modules.

Details

SubjectRepoBranchLines +/-
[WIP] AQllow entity creation from API modules that use EntitySavingHelpermediawiki/extensions/Wikibasemaster+43 -0
Fix doc and consistency issues in EntitySavingHelper(Test)mediawiki/extensions/Wikibasemaster+25 -17
Fix bad check for $revid.mediawiki/extensions/Wikibasemaster+5 -1
Move logic for creating entities on the fly into EntitySavingHelper.mediawiki/extensions/Wikibasemaster+680 -341
Move logic for getting IDs from parameters into EntityLoadingHelper.mediawiki/extensions/Wikibasemaster+300 -174
Generic handling of baserevid for EntitySavingHelpermediawiki/extensions/Wikibasemaster+135 -96
Make EntitySavingHelper extend EntityLoadingHelper.mediawiki/extensions/Wikibasemaster+102 -114
Customize query in gerrit

Related Objects
Search...

Event Timeline

Tobi_WMDE_SW created this task.Jul 19 2016, 2:16 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJul 19 2016, 2:16 PM
Tobi_WMDE_SW added a parent task: T134473: Create MediaInfo / Linking multimedia files to their mediainfo entity (second prototype).Jul 19 2016, 2:17 PM
Tobi_WMDE_SW mentioned this in T134259: [Task] Create mediainfo entity on demand when saving the first time after editing labels, descriptions and aliases.
Tobi_WMDE_SW added a subscriber: daniel.Jul 19 2016, 2:20 PM

@daniel if there are already patches up that go in this direction, can you please link them?

gerritbot subscribed.Jul 20 2016, 1:04 PM

Change 294365 had a related patch set uploaded (by Tobias Gritschacher):
Allow entities to be created from more API modules.

https://gerrit.wikimedia.org/r/294365

gerritbot added a project: Patch-For-Review.Jul 20 2016, 1:04 PM
Tobi_WMDE_SW added a comment.Jul 20 2016, 1:05 PM

@daniel I've changed the commit message of https://gerrit.wikimedia.org/r/294365 to point to this task.

gerritbot added a comment.Jul 20 2016, 3:03 PM

Change 294365 had a related patch set uploaded (by Daniel Kinzler):
Allow entities to be created from more API modules.

https://gerrit.wikimedia.org/r/294365

Lydia_Pintscher added a project: Wikidata-Sprint-2016-08-02.Aug 2 2016, 10:12 AM
thiemowmde moved this task from Proposed to Backlog on the Wikidata-Sprint-2016-08-02 board.Aug 2 2016, 1:09 PM
thiemowmde triaged this task as Medium priority.Aug 8 2016, 3:05 PM
thiemowmde edited projects, added MediaWiki-extensions-WikibaseRepository; removed Patch-For-Review.
thiemowmde updated the task description. (Show Details)
thiemowmde edited subscribers, added: thiemowmde, • Jonas, Lydia_Pintscher; removed: gerritbot.
gerritbot added a comment.Aug 8 2016, 5:48 PM

Change 303585 had a related patch set uploaded (by Daniel Kinzler):
Make EntitySavingHelper extend EntityLoadingHelper.

https://gerrit.wikimedia.org/r/303585

gerritbot added a comment.Aug 8 2016, 6:40 PM

Change 303600 had a related patch set uploaded (by Daniel Kinzler):
Generic handling of baserevid for EntitySavingHelper

https://gerrit.wikimedia.org/r/303600

gerritbot added a comment.Aug 9 2016, 3:59 PM

Change 303812 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Fix doc and consistency issues in EntitySavingHelper(Test)

https://gerrit.wikimedia.org/r/303812

gerritbot added a comment.Aug 9 2016, 4:08 PM

Change 303585 merged by jenkins-bot:
Make EntitySavingHelper extend EntityLoadingHelper.

https://gerrit.wikimedia.org/r/303585

gerritbot added a comment.Aug 9 2016, 6:04 PM

Change 303844 had a related patch set uploaded (by Daniel Kinzler):
[WIP] Move logic for getting IDs from parameters into EntityLoadingHelper.

https://gerrit.wikimedia.org/r/303844

gerritbot added a comment.Aug 11 2016, 3:45 PM

Change 303600 merged by jenkins-bot:
Generic handling of baserevid for EntitySavingHelper

https://gerrit.wikimedia.org/r/303600

• Jonas assigned this task to daniel.Aug 12 2016, 11:35 AM
• Jonas moved this task from Backlog to Doing on the Wikidata-Sprint-2016-08-02 board.
thiemowmde moved this task from Doing to Review on the Wikidata-Sprint-2016-08-02 board.Aug 16 2016, 12:35 PM
thiemowmde added a project: Wikidata-Sprint-2016-08-16.Aug 16 2016, 12:57 PM
thiemowmde moved this task from Proposed to Review on the Wikidata-Sprint-2016-08-16 board.Aug 16 2016, 1:05 PM
gerritbot added a comment.Aug 17 2016, 4:36 PM

Change 303844 merged by jenkins-bot:
Move logic for getting IDs from parameters into EntityLoadingHelper.

https://gerrit.wikimedia.org/r/303844

gerritbot added a comment.Aug 19 2016, 1:32 AM

Change 303616 merged by jenkins-bot:
Move logic for creating entities on the fly into EntitySavingHelper.

https://gerrit.wikimedia.org/r/303616

hoo updated the task description. (Show Details)Aug 19 2016, 1:48 AM
hoo updated the task description. (Show Details)
thiemowmde added a comment.Aug 19 2016, 2:02 PM

I believe this is done, but have not confirmed.

hoo subscribed.Aug 19 2016, 2:14 PM
In T140760#2567482, @thiemowmde wrote:

I believe this is done, but have not confirmed.

The second bullet point from the task description is still open, isn't it?

gerritbot added a comment.Aug 23 2016, 4:04 PM

Change 306236 had a related patch set uploaded (by Daniel Kinzler):
Fix bad check for $revid.

https://gerrit.wikimedia.org/r/306236

gerritbot added a project: Patch-For-Review.Aug 23 2016, 4:04 PM
gerritbot added a comment.Aug 24 2016, 9:29 AM

Change 306236 merged by jenkins-bot:
Fix bad check for $revid.

https://gerrit.wikimedia.org/r/306236

daniel closed this task as Resolved.Aug 24 2016, 9:31 AM
daniel moved this task from Review to Done on the Wikidata-Sprint-2016-08-16 board.
gerritbot added a comment.Aug 27 2016, 10:26 PM

Change 303812 merged by jenkins-bot:
Fix doc and consistency issues in EntitySavingHelper(Test)

https://gerrit.wikimedia.org/r/303812

gerritbot added a comment.Jun 18 2018, 10:42 AM

Change 294521 abandoned by Daniel Kinzler:
[WIP] AQllow entity creation from API modules that use EntitySavingHelper

https://gerrit.wikimedia.org/r/294521

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits