⚓ T138413 Form styles are missing on Wikibase special pages in mobile view

	Subject	Repo	Branch	Lines +/-
	Add mediawiki.ui.input for all SpecialModifyEntity pages	mediawiki/extensions/Wikibase	master	+3 -2
	Fix: Form styles are missing on Wikibase special pages in mobile view	mediawiki/extensions/Wikibase	master	+2 -0

aude created this task.Jun 22 2016, 3:09 PM

Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJun 22 2016, 3:09 PM

aude triaged this task as High priority.Jun 22 2016, 3:10 PM

Sjoerddebruin subscribed.Jun 22 2016, 3:29 PM

https://m.wikidata.org/wiki/Special:Search is also missing styles

Jdlrobson added a project: Web-Team-Backlog.Jun 22 2016, 5:08 PM

Jdlrobson moved this task from Incoming to 2014-15 Q4 on the Web-Team-Backlog board.

aude mentioned this in T138578: [Regression] en.wikipedia.org Mobile main page no longer being transformed.Jun 24 2016, 12:40 PM

aude added a project: Wikidata-Sprint-2016-07-05.Jul 5 2016, 1:28 PM

Tobi_WMDE_SW moved this task from Proposed to Backlog on the Wikidata-Sprint-2016-07-05 board.Jul 5 2016, 1:28 PM

This block is missing:

.mw-ui-input {
    -webkit-box-sizing: border-box;
    -moz-box-sizing: border-box;
    box-sizing: border-box;
    display: block;
    width: 100%;
    border: 1px solid #cccccc;
    border-radius: 2px;
    padding: 0.3em 0.3em 0.3em 0.6em;
    font-family: inherit;
    font-size: inherit;
    line-height: inherit;
    vertical-align: middle;
}

Some change in MobileFrontend has made it disappear.

• Jonas claimed this task.Jul 11 2016, 9:36 AM

• Jonas moved this task from Backlog to Doing on the Wikidata-Sprint-2016-07-05 board.

Change 298259 had a related patch set uploaded (by Jonas Kress (WMDE)):
Fix: Form styles are missing on Wikibase special pages in mobile view

https://gerrit.wikimedia.org/r/298259

gerritbot added a project: Patch-For-Review.Jul 11 2016, 9:44 AM

Just uploaded a quick fix.

I think we should convert the form to OOUI form, to have a clean fix.
Maybe something @Ricordisamoa would like to do.

• Jonas moved this task from Doing to Review on the Wikidata-Sprint-2016-07-05 board.Jul 11 2016, 9:47 AM

Change 298259 merged by jenkins-bot:
Fix: Form styles are missing on Wikibase special pages in mobile view

https://gerrit.wikimedia.org/r/298259

Just a note it has always been the case that mediawiki.ui.input has to be explicitly added to special pages.

Jdlrobson removed a project: Patch-For-Review.Jul 12 2016, 7:00 PM

thiemowmde closed this task as Resolved.Jul 15 2016, 8:44 AM

thiemowmde moved this task from Review to Done on the Wikidata-Sprint-2016-07-05 board.

Change 299161 had a related patch set uploaded (by Aude):
Add mediawiki.ui.input for all SpecialModifyEntity pages

https://gerrit.wikimedia.org/r/299161

gerritbot added a project: Patch-For-Review.Jul 15 2016, 3:15 PM

Change 299161 merged by jenkins-bot:
Add mediawiki.ui.input for all SpecialModifyEntity pages

https://gerrit.wikimedia.org/r/299161

Appears to not be done, at least https://test.m.wikidata.org/wiki/Special:SetSiteLink/Q2205 is still unstyled. I assume there is a CSS class name missing on the form or something.

thiemowmde moved this task from Done to Backlog on the Wikidata-Sprint-2016-07-05 board.Jul 19 2016, 12:34 PM

Tobi_WMDE_SW added a project: Wikidata-Sprint-2016-07-19.Jul 19 2016, 12:51 PM

Tobi_WMDE_SW moved this task from Proposed to Backlog on the Wikidata-Sprint-2016-07-19 board.Jul 19 2016, 12:52 PM