Page MenuHomePhabricator
Create Task
Maniphest T108242

Normalize currency_code to uppercase
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

We should be able to accept lowercase currency codes from incoming links and normalize them to upper case. Currently we treat lowercase as an unsupported currency, show an error, and make the user choose an amount an currency.

Details

SubjectRepoBranchLines +/-
Normalize currency_code to uppercasemediawiki/extensions/DonationInterfacemaster+7 -5
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedNoneT106050 Diagnose AstroPay ffname errors
 ResolvedEjeggT108242 Normalize currency_code to uppercase

Event Timeline

Ejegg created this task.Aug 6 2015, 8:43 PM
Ejegg claimed this task.
Ejegg raised the priority of this task from to Needs Triage.
Ejegg updated the task description. (Show Details)
Ejegg added projects: MediaWiki-extensions-DonationInterface, Fundraising-Backlog.
Ejegg subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 6 2015, 8:43 PM
• atgo subscribed.Aug 6 2015, 8:49 PM

Is this related to Astropay?

gerritbot subscribed.Aug 6 2015, 8:49 PM

Change 229948 had a related patch set uploaded (by Ejegg):
Normalize currency_code to uppercase

https://gerrit.wikimedia.org/r/229948

gerritbot added a project: Patch-For-Review.Aug 6 2015, 8:49 PM
Ejegg added a comment.Aug 6 2015, 8:54 PM

Yep @atgo, it's the main reason for those ffname errors.

• atgo added a parent task: T106050: Diagnose AstroPay ffname errors.Aug 6 2015, 8:56 PM

Awesome. Should we pull this into sprint?

Ejegg added a project: Fundraising Sprint Queen.Aug 6 2015, 8:58 PM

Might as well - the code's already written!

Ejegg mentioned this in T106050: Diagnose AstroPay ffname errors.Aug 6 2015, 9:05 PM
• atgo added a project: Unplanned-Sprint-Work.Aug 6 2015, 9:07 PM
• atgo set Security to None.
Ejegg moved this task from Backlog to Pending Deployment on the Fundraising Sprint Queen board.Aug 6 2015, 9:38 PM
gerritbot added a comment.Aug 6 2015, 9:41 PM

Change 229948 merged by jenkins-bot:
Normalize currency_code to uppercase

https://gerrit.wikimedia.org/r/229948

Ejegg mentioned this in rMEXTd2c8d578dfff: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….Aug 6 2015, 9:42 PM
Ejegg mentioned this in rEDOI574919cdd14b: Normalize currency_code to uppercase.
Ejegg closed this task as Resolved.Aug 6 2015, 9:55 PM
Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint Queen board.
Ejegg edited a custom field.
• atgo moved this task from Triage to Closed Sprint Work Q1 1516 on the Fundraising-Backlog board.Aug 7 2015, 4:47 PM
• DStrine removed a project: Unplanned-Sprint-Work.Aug 20 2015, 4:52 PM
• DStrine added a project: Essential-Work.Aug 27 2015, 5:39 PM
• DStrine edited projects, added Fr-tech-archived-from-FY-2015/16; removed Fundraising-Backlog.Jan 11 2018, 9:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits