It is duplicate of T51068, but that task was closed as declined a year ago.

I thought it seemed obvious but couldn't find that, thanks. Looks like it
was closed as it should start life as a gadget, but no one ever made one?
Alas.
matej_suchanek added a subscriber: matej_suchanek.
matej_suchanek added a comment.

It is duplicate of https://phabricator.wikimedia.org/T51068, but that task
was closed as declined a year ago.

TASK DETAIL

https://phabricator.wikimedia.org/T107693

EMAIL PREFERENCES

https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matej_suchanek
Cc: matej_suchanek, Aklapper, Mvolz, Wikidata-bugs, aude, Malyacko, P.Copp

Adding into Wikidata-Gadgets project.

Now that there is a text showing up during no results, it should be much easier to create a gadget. A link to a pre-filled Special:NewItem would do.

@Ladsgroup: If you plan to mentor this in GCi2017, could you edit the task description and explain which exact odebase(s) this task is about? Thanks!

In T107693#3786916, @Aklapper wrote:

@Ladsgroup: If you plan to mentor this in GCi2017, could you edit the task description and explain which exact odebase(s) this task is about? Thanks!

Whoops, I misread that as GSoC and just expanded it to be more GSoC-y. It could *potentially* be a fairly involved project.

But just adding the link would be a great first step - but the discussion seems to be talking about making a gadget. If it's just the link, that seems like something simple that could be added directly to wikibase?

I am not convinced this is a beneficial change which is why I want this to be trialed as a gadget first.

In T107693#3786916, @Aklapper wrote:

@Ladsgroup: If you plan to mentor this in GCi2017, could you edit the task description and explain which exact odebase(s) this task is about? Thanks!

The codebase about this would be a user script (User:Foo/common.js) and they way to test it, would be to copy paste it in console. Is this enough?

Thanks! "Create a gadget" published as https://codein.withgoogle.com/tasks/4740710156730368/

I guess that this gadget will have to override _initMenu function in jquery.wikibase.entityselector.js and replace the null with the open new URL function?

customItems.unshift( new $.ui.ooMenu.CustomItem(
    this.options.messages.notfound,
    function () {
      return self._cache.suggestions && !self._cache.suggestions.length
        && self.element.val().trim() !== '';
    },
    null,
    'ui-entityselector-notfound'
  ) );

But I can't find how to do this with user script. Or is there any other easier method?

You should be able to traverse the DOM with JS to insert it directly into
the menu. Try inspecting the element using your browser's debugger to see
where that would be.

I guess the hard part is when the script should be triggered; maybe on
typing in the box? And check every time to see if the list has no results
and then replace it?

(If nothing I'm typing is making sense please ask for clarification :))

https://www.wikidata.org/wiki/User:Eflyjason/Gadget-CreateNewItem.js

var currentFieldText = "";
$(document).on('input propertychange paste', ".ui-suggester-input", function() {
	currentFieldText = $(this).val();
	//console.log("Entering: "+currentFieldText);
});
$(document).on('DOMSubtreeModified', ".ui-entityselector-list",function(){
	var firstLi = $(this).find("li").first();
	var isNotFound = firstLi.hasClass('ui-entityselector-notfound');
	console.log('Current Text Field content: '+currentFieldText+". Not found: "+isNotFound);
	if(isNotFound){
		var innerA = firstLi.find("a").first();
		innerA.attr("href", "https://www.wikidata.org/wiki/Special:NewItem?label="+currentFieldText).attr("target", "_blank");
	}
});

The basic feature should be working right now :D (though I'm not sure if it's the best approach?)

I will optimize it and make it into a popup later :D

https://www.wikidata.org/w/index.php?title=User:Eflyjason/Gadget-CreateNewItem.js&oldid=606396356 the popup is working too :D

Great so far! Is it possible to use OOjs UI for the popup though? We are slowly transforming our current gadgets to it. The form will automatically look correct as well then.

In T107693#3825308, @eflyjason wrote:

https://www.wikidata.org/w/index.php?title=User:Eflyjason/Gadget-CreateNewItem.js&oldid=606396356 the popup is working too :D

Nice!

But I'm getting an error when trying to create an item from the pop-up

"[Wiws9wpAME0AABYAle0AAABL] 2017-12-09 18:35:51: Fatal exception of type "Wikimedia\Rdbms\DBQueryError"

Also it would be nice if there was some indication that you can click on the no results found link - like making a "create new item" link and have it be underlined, so people know it's clickable.

I don't want feature creep on this, honestly having the pop-up at all is great (even if it isn't OOUI) - it *is* supposed to be a small task!

https://www.wikidata.org/w/index.php?title=User:Eflyjason/Gadget-CreateNewItem.js&oldid=606566480

In T107693#3825336, @Sjoerddebruin wrote:

Great so far! Is it possible to use OOjs UI for the popup though? We are slowly transforming our current gadgets to it. The form will automatically look correct as well then.

Updated with OOjs UI :D

In T107693#3825793, @Mvolz wrote:

Also it would be nice if there was some indication that you can click on the no results found link - like making a "create new item" link and have it be underlined, so people know it's clickable.

Added :)

In T107693#3825793, @Mvolz wrote:

But I'm getting an error when trying to create an item from the pop-up

"[Wiws9wpAME0AABYAle0AAABL] 2017-12-09 18:35:51: Fatal exception of type "Wikimedia\Rdbms\DBQueryError"

That's weird. I tested again and created entity successfully.

There are some problems related performance I think caused by DOMSubtreeModified. It would be nice if there are .on for detecting the list change directly.

In T107693#3825793, @Mvolz wrote:

"[Wiws9wpAME0AABYAle0AAABL] 2017-12-09 18:35:51: Fatal exception of type "Wikimedia\Rdbms\DBQueryError"

Looks like a temp. problem T182505.

I saw that the script also affects the property input field, I don't think that should be happening.

In T107693#3826291, @Sjoerddebruin wrote:

I saw that the script also affects the property input field, I don't think that should be happening.

Fixed :D

https://www.wikidata.org/w/index.php?title=User:Eflyjason/Gadget-CreateNewItem.js&oldid=606686398

In T107693#3826384, @eflyjason wrote:

In T107693#3826291, @Sjoerddebruin wrote:

I saw that the script also affects the property input field, I don't think that should be happening.

Fixed :D

https://www.wikidata.org/w/index.php?title=User:Eflyjason/Gadget-CreateNewItem.js&oldid=606686398

Would you like to submit this work for review on the google code-in website? We can't approve it unless that is done :).

In T107693#3826552, @Mvolz wrote:

Would you like to submit this work for review on the google code-in website? We can't approve it unless that is done :).

Thank you! I've added it to https://www.wikidata.org/wiki/Wikidata:Tools/User_scripts#AddNewItem and also localized the script in Chinese. :D

Removing the Possible-Tech-Projects tag as we are planning to kill it soon! This project does not seem to fit in the Outreach-Programs-Projects category in its current state, so I am not adding that tag right now!

I'm o

It would be great if the script allowed to create a new item even if there are (irrelevant) results.

I tried porting this script to use the new mutation observer but failed.
For some reason after making the replace the entityselector resets and the replacement disappears.

Further complicating matters is that there are multiple entityselector lists hidden in the background and it is impossible to know which one is related to the current textarea.

Further complicating matters is that there can be multiple textareas on the page at the same time and the script has no idea which entityselector corresponds to which textarea.

My conclusion is that this cannot be done well with a user script at this time. If textareas were given an id and the corresponding entityselector list a similar id it would be easier to distinguish. see https://phabricator.wikimedia.org/T290298

See https://www.wikidata.org/wiki/User:So9q/CreateNewEntity.js

I did succeed in getting it usable on lexemes though before the reset bug appeared a while back :)

I had another go at a userscript for this. See https://www.wikidata.org/wiki/User:Zvpunry/CreateNewItem for instructions how to use it.