Page MenuHomePhabricator
Create Task
Maniphest T105411

Diffs should link to properties
Closed, ResolvedPublic
Actions

Description

Currently, diffs display "property / [property label]" as the section for main claims, and "property / [property label]: [value] / qualifier" as the section for qualifiers, with "[property label]: [value]" as the qualifier content. In all of these the property label is unlinked. Linking the labels to the property pages would make understanding changes and navigating somewhat easier.

Details

SubjectRepoBranchLines +/-
Link to property pages in statement diffsmediawiki/extensions/Wikibasemaster+2 -4
Customize query in gerrit

Related Objects

Event Timeline

Yair_rand created this task.Jul 9 2015, 10:36 PM
Yair_rand raised the priority of this task from to Needs Triage.
Yair_rand updated the task description. (Show Details)
Yair_rand added a project: Wikidata.
Yair_rand subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 9 2015, 10:36 PM
matej_suchanek subscribed.Jul 10 2015, 6:23 AM

Applying language fallback as well.

matej_suchanek added a project: MediaWiki-extensions-WikibaseRepository.Jul 15 2015, 8:02 AM
matej_suchanek set Security to None.
Ricordisamoa claimed this task.Aug 22 2015, 1:34 PM
Ricordisamoa subscribed.
gerritbot subscribed.Aug 22 2015, 1:38 PM

Change 233110 had a related patch set uploaded (by Ricordisamoa):
Link to property pages in statement diffs

https://gerrit.wikimedia.org/r/233110

gerritbot added a project: Patch-For-Review.Aug 22 2015, 1:38 PM
Ricordisamoa added a comment.EditedAug 23 2015, 1:09 PM
beforeafter
before.png (558×1 px, 52 KB)
after.png (558×1 px, 57 KB)

(the <b>s are actually in the property's label, to ensure HTML is properly escaped)

gerritbot added a comment.Aug 26 2015, 8:49 AM

Change 233110 merged by jenkins-bot:
Link to property pages in statement diffs

https://gerrit.wikimedia.org/r/233110

Diffusion mentioned this in rMEXT37edf0e4d5dd: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Aug 26 2015, 8:49 AM
Addshore mentioned this in rEWBAfefda81ca29e: Link to property pages in statement diffs.Aug 26 2015, 8:50 AM
Ricordisamoa closed this task as Resolved.Aug 26 2015, 9:08 AM
Ricordisamoa removed a project: Patch-For-Review.
Ricordisamoa removed a subscriber: gerritbot.
Lydia_Pintscher added a project: Wikidata-Sprint-2015-08-18.Aug 26 2015, 9:24 AM
Lydia_Pintscher moved this task from Backlog to Done on the Wikidata-Sprint-2015-08-18 board.
Lydia_Pintscher subscribed.
Ricordisamoa added a comment.Sep 9 2015, 11:52 PM
In T105411#1443997, @matej_suchanek wrote:

Applying language fallback as well.

https://gerrit.wikimedia.org/r/236942 should work.

matej_suchanek unsubscribed.Oct 21 2015, 2:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits