Page MenuHomePhabricator
Create Task
Maniphest T104309

[Task] Move PropertySuggester extension to gerrit
Closed, ResolvedPublic
Actions

Description

Details

SubjectRepoBranchLines +/-
Stop updating PropertySuggester in github.translatewikimaster+0 -17
Make builder use gerrit instead of github for PropertySuggesterwikidata/build-resourcesmaster+5 -1
Make jenkins pass on mastermediawiki/extensions/PropertySuggestermaster+96 -31
Add PropertySuggesterintegration/configmaster+9 -0
Use PropertySuggester in gerrit instead of githubmediawiki/extensions/Wikidatamaster+25 -22
Add .gitreviewmediawiki/extensions/PropertySuggestermaster+6 -0
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedAddshoreT173818 [Epic] Kill the Wikidata build step
 ResolvedAddshoreT181709 Cleanup Phabricator tickets once the build is dead
 InvalidNoneT108946 [Epic] Improve the development infrastructure
DeclinedNoneT74907 [Task] move git repositories that are dependencies of wikidata to gerrit
 DeclinedNoneT87768 [Task] trigger packagist.org from repo on gerrit.w.o
 ResolvedJanZerebeckiT102629 Request Gerrit repository for WikibaseDataModelServices
 ResolvedJeroenDeDauwT93741 [RFC] Create place to put common Wikibase services
 ResolvedaudeT111173 [Task] Move WikidataBuildResources to gerrit
 ResolvedJanZerebeckiT112120 [Task] Move ValueView repository from github to gerrit
 DuplicateNoneT114649 delete mediawiki/extensions/ValueView from gerrit
 DeclinedNoneT126597 [Task] Move WikibaseDataModel to Gerrit
 ResolvedLadsgroupT127292 [Task] Move DataTypes repository from Github to gerrit
 ResolvedJanZerebeckiT131138 [Task] move WikidataBrowserTests from github to gerrit
 DeclinedNoneT95663 [Story] Use composer-merge-plugin to include Wikidata components in mediawiki-vendor
 ResolvedaudeT95673 Add inital support in WikidataBuildResources for install via composer-merge-plugin
 ResolvedJeroenDeDauwT97560 enable use of a composer created autoloader in extensions deployed to production
 ResolvedWMDE-leszekT101164 [Task] make ValueView into a lib or do not require it via composer.json
 InvalidNoneT102246 [Task] extensions may not use class_exists to check if an extension is loaded
 InvalidNoneT92980 [Story] Convert all extensions that are part of the Wikidata build to use the new extension registration
 ResolvedNoneT88258 Convert WikibaseRepository, WikibaseClient, WikibaseLib and WikibaseView to use extension registration
 ResolvedVictorbarbuT119766 Composer's autoloader should be autoloaded in extension registry (if configured)
 ResolvedLucas_Werkmeister_WMDET223214 Start converting Wikibase extensions to use extension registration
 ResolvedLadsgroupT256228 Convert WikibaseClient to use extension registration
 ResolvedLucas_Werkmeister_WMDET256238 Remove WB_VERSION, WBL_VERSION, WBC_VERSION constants
 DeclinedTarrowT256241 Check whether Client can load Lib without PHP entry point
 ResolvedLucas_Werkmeister_WMDET256243 Migrate Client API modules to extension JSON file
 ResolvedLucas_Werkmeister_WMDET256244 Migrate client $wgExtensionFunctions to extension JSON
 ResolvedLadsgroupT256245 Migrate Client i18n globals to extension JSON
 ResolvedNoneT256246 Migrate Client hooks to extension JSON
 ResolvedLadsgroupT256253 Stop registering some Client hooks only outside of unit tests
 ResolvedLucas_Werkmeister_WMDET256257 Migrate ClientHooks hook handlers to extension JSON
 ResolvedTarrowT256259 Migrate Client ChangesListLinesHandler hooks to extension JSON
 ResolvedLucas_Werkmeister_WMDET256260 Migrate Client SidebarHookHandlers hooks to extension JSON
 ResolvedLucas_Werkmeister_WMDET256261 Migrate Client MovePageNotice hook to extension JSON
 ResolvedLucas_Werkmeister_WMDET256262 Migrate Client InfoActionHookHandler hook to extension JSON
 ResolvedLucas_Werkmeister_WMDET256263 Migrate Client ParserLimitReportPrepareHookHandler hook to extension JSON
 ResolvedLucas_Werkmeister_WMDET256264 Migrate Client ParserClearStateHookHandler hook to extension JSON
 ResolvedLadsgroupT256265 Migrate Client EchoSetupHookHandlers hook to extension JSON
 ResolvedLadsgroupT256266 Migrate Client EchoNotificationsHandlers hook to extension JSON
 ResolvedLadsgroupT256267 Migrate Client DataUpdateHookHandlers hooks to extension JSON
 ResolvedLadsgroupT256268 Migrate Client UpdateRepoHookHandlers hooks to extension JSON
 ResolvedLadsgroupT256269 Migrate Client ChangesListSpecialPageHookHandlers hook to extension JSON
 ResolvedLadsgroupT256270 Migrate Client SqlUsageTrackerSchemaUpdater hook to extension JSON
 ResolvedLadsgroupT256271 Migrate Client DescriptionProviderHookHandler hook to extension JSON
 ResolvedLucas_Werkmeister_WMDET256764 Migrate Client ParserOutputUpdateHookHandlers hooks to extension JSON
 ResolvedLadsgroupT256247 Migrate Client job classes to extension JSON
 ResolvedItamarWMDET256248 Migrate Client $wgRecentChangesFlags to extension JSON
 ResolvedLucas_Werkmeister_WMDET256249 Migrate Client ResourceLoader modules (except Data Bridge) to extension JSON
 ResolvedLadsgroupT256250 Migrate Client Data Bridge ResourceLoader modules to extension JSON
 ResolvedItamarWMDET256251 Migrate Client special pages to extension JSON
 ResolvedLucas_Werkmeister_WMDET256252 Migrate wgWBClientDataTypes + wgWBClientSettings loading out of Client PHP entry point
 ResolvedLucas_Werkmeister_WMDET256756 Remove $wgWBRepoDataTypes and $wgWBClientDataTypes global variables
 ResolvedLadsgroupT257430 Copy Lib extension.json content to Client
 ResolvedLadsgroupT257431 Copy Lib extension.json content to Repo
 ResolvedLadsgroupT257432 Remove Lib extension.json
 ResolvedLadsgroupT257433 Convert Repo to use Extension Registration
 ResolvedLucas_Werkmeister_WMDET257441 Migrate Repo permissions to extension JSON file
 ResolvedLucas_Werkmeister_WMDET257442 Migrate Repo i18n globals to extension JSON file
 ResolvedLucas_Werkmeister_WMDET257443 Migrate Repo API modules to extension JSON file
 ResolvedLadsgroupT257444 Migrate Repo special pages to extension JSON file
 ResolvedNoneT257445 Migrate Repo hooks to extension JSON file
 ResolvedLadsgroupT257563 Migrate DatabaseSchemaUpdater hook handler to json
 ResolvedLadsgroupT257564 Migrate HtmlPageLinkRendererEndHookHandler to json
 ResolvedLadsgroupT257565 Migrate LabelPrefetchHookHandlers to json
 ResolvedTarrowT257566 Migrate ShowSearchHitHandler to json
 ResolvedItamarWMDET257567 Migrate OutputPageBeforeHTMLHookHandler to json
 ResolvedLadsgroupT257568 Migrate OutputPageJsConfigHookHandler to json
 ResolvedLadsgroupT257569 Migrate ArticleRevisionVisibilitySetHookHandler to json
 ResolvedItamarWMDET257570 Migrate ChangesSubscriptionSchemaUpdater to json
 ResolvedItamarWMDET257615 Migrate FederatedPropertiesSpecialPageHookHandler to json
 ResolvedLadsgroupT257446 Migrate Repo ResourceLoader modules to extension JSON file
 ResolvedLadsgroupT257447 Don’t load Repo settings in PHP entry point
 ResolvedLadsgroupT257448 Don’t define Repo content model constants in PHP entry point
 ResolvedLucas_Werkmeister_WMDET257449 Remove WB_NO_CONFIGURE_EXAMPLE_REPO constant / hack
 ResolvedLadsgroupT258043 Merge WikibaseView extension registeration into Repo
 ResolvedLadsgroupT257436 Deploy Repo using extension registration to Beta
 ResolvedMtDuT106104 [Task] Convert WikibaseQuality, WikibaseQualityConstraints and WikibaseQualityExternalValidation to use extension registration
 ResolvedLydia_PintscherT161716 Turn WikibaseQualityExternalValidation constants into config variables
 DeclinedLydia_PintscherT106635 Convert WikibaseQuery to use extension registration
 InvalidNoneT123026 change Wikidata build to load its included extensions via extension registration
 InvalidNoneT124054 [Task] Convert wikibase and data values libraries to use extension registration
 ResolvedReedyT124055 [Task] Convert PropertySuggester to use extension registration
 ResolvedLegoktmT168187 Convert Wikidata.org to use extension registration
 ResolvedLadsgroupT104309 [Task] Move PropertySuggester extension to gerrit
 ResolvedNoneT92520 Move Wikidata.org and WikimediaBadges extensions to gerrit
 ResolvedJanZerebeckiT102628 Request Gerrit repositories for Wikidata.org and WikimediaBadges
 ResolvedNoneT90303 Fetch dependencies using composer instead of cloning mediawiki/vendor for non-wmf branches
 ResolvedJanZerebeckiT106433 replace inline perl in builder wd-mw-composer-merged-install with a proper script
 ResolvedKrinkleT112895 Support installing composer require-dev packages together with mediawiki/vendor
 InvalidNoneT109171 [RFC] wikibase (composer) libraries register resource loader modules during autoloader startup
 ResolvedJanZerebeckiT112572 [Task] make Wikibase work in WM CI without special config
 ResolvedAddshoreT147215 Improve version information for Wikidata software components

Event Timeline

JanZerebecki created this task.Jun 30 2015, 10:48 AM
JanZerebecki raised the priority of this task from to Medium.
JanZerebecki updated the task description. (Show Details)
JanZerebecki added projects: Gerrit-Migration, Wikidata.
JanZerebecki added subscribers: Addshore, Liuxinyu970226, Ricordisamoa and 19 others.
JanZerebecki moved this task from incoming to ready to go on the Wikidata board.Jun 30 2015, 1:23 PM
Addshore awarded a token.Jul 15 2015, 11:17 AM
JanZerebecki added a parent task: T95663: [Story] Use composer-merge-plugin to include Wikidata components in mediawiki-vendor.Jul 21 2015, 10:32 PM
• Jonas added a parent task: T108946: [Epic] Improve the development infrastructure .Aug 13 2015, 2:28 PM
• Jonas renamed this task from Move PropertySuggester extension to gerrit to [Task] Move PropertySuggester extension to gerrit.Aug 13 2015, 4:17 PM
• Jonas set Security to None.
greg edited projects, added Gerrit; removed Gerrit-Migration.Dec 2 2015, 12:26 AM
aude mentioned this in T122041: add i18n for property suggester api module.Dec 21 2015, 10:59 AM
• demon moved this task from Bugs & stuff to Repo Admin on the Gerrit board.Jul 25 2016, 3:47 PM
Ladsgroup added a project: Wikidata-Former-Sprint-Board.May 15 2017, 1:12 PM
Ladsgroup moved this task from ready to go to in progress on the Wikidata board.May 15 2017, 1:29 PM
Ladsgroup claimed this task.May 15 2017, 3:53 PM
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptMay 15 2017, 3:53 PM
Ladsgroup moved this task from Proposed to Doing on the Wikidata-Former-Sprint-Board board.May 15 2017, 3:55 PM
greg reassigned this task from Ladsgroup to • demon.May 19 2017, 11:50 AM
greg added a subscriber: Ladsgroup.
Restricted Application added a project: Release-Engineering-Team (Kanban). · View Herald TranscriptMay 19 2017, 11:50 AM
Ladsgroup moved this task from Incoming to Monitor on the User-Ladsgroup board.May 20 2017, 7:45 AM
gerritbot subscribed.May 21 2017, 12:31 PM

Change 354965 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/PropertySuggester@master] Add .gitreview

https://gerrit.wikimedia.org/r/354965

gerritbot added a project: Patch-For-Review.May 21 2017, 12:32 PM
Ladsgroup claimed this task.May 21 2017, 12:33 PM
Ladsgroup added a subscriber: • demon.
gerritbot added a comment.May 21 2017, 1:23 PM

Change 354980 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/Wikidata@master] Use PropertySuggester in gerrit instead of github

https://gerrit.wikimedia.org/r/354980

gerritbot added a comment.May 22 2017, 10:35 AM

Change 354965 merged by Hashar:
[mediawiki/extensions/PropertySuggester@master] Add .gitreview

https://gerrit.wikimedia.org/r/354965

gerritbot added a comment.May 22 2017, 3:25 PM

Change 355120 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[wikidata/build-resources@master] Make builder use gerrit instead of github for PropertySuggester

https://gerrit.wikimedia.org/r/355120

gerritbot added a comment.May 22 2017, 3:30 PM

Change 354980 abandoned by Ladsgroup:
Use PropertySuggester in gerrit instead of github

Reason:
Done in I326f3cd4fed8ec07f812a631fc63f82f8f940376

https://gerrit.wikimedia.org/r/354980

Ladsgroup mentioned this in rWDBR91f0279f5792: Make builder use gerrit instead of github for PropertySuggester.May 22 2017, 3:33 PM
Ladsgroup moved this task from Doing to Review on the Wikidata-Former-Sprint-Board board.May 22 2017, 3:45 PM
Ladsgroup added a comment.May 22 2017, 3:47 PM

Most of it is being done but there are two things needing to be done:

  • Update packagist, I don't how to do it or if it's needed
  • Make jenkins run on this properly.
gerritbot added a comment.May 22 2017, 3:53 PM

Change 355124 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[integration/config@master] Add PropertySuggester

https://gerrit.wikimedia.org/r/355124

Tobi_WMDE_SW added a comment.May 22 2017, 4:05 PM

I guess we would also need to somehow also port the releases over to Gerrit, no?

Ladsgroup added a comment.May 22 2017, 4:12 PM

We can also go with dev-master like Wikibase and other gerrit extensions.

greg subscribed.May 22 2017, 8:10 PM

Looks like the gerrit repo admin part is done, right? Can I remove releng-related projects now?

Ladsgroup added a comment.May 22 2017, 8:15 PM

@greg: Yes, thank you for doing it.

Legoktm added a comment.May 22 2017, 8:25 PM
In T104309#3284494, @Tobi_WMDE_SW wrote:

I guess we would also need to somehow also port the releases over to Gerrit, no?

Releases are just git tags. Should be simple to clone the repository and then re-push it.

greg removed projects: Release-Engineering-Team (Kanban), Gerrit.May 22 2017, 8:28 PM
gerritbot added a comment.May 23 2017, 8:40 AM

Change 355124 merged by jenkins-bot:
[integration/config@master] Add PropertySuggester

https://gerrit.wikimedia.org/r/355124

gerritbot added a comment.May 23 2017, 11:57 AM

Change 355204 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/PropertySuggester@master] Add package.json

https://gerrit.wikimedia.org/r/355204

gerritbot added a comment.May 24 2017, 10:09 AM

Change 355204 merged by jenkins-bot:
[mediawiki/extensions/PropertySuggester@master] Make jenkins pass on master

https://gerrit.wikimedia.org/r/355204

Qgil unsubscribed.May 24 2017, 1:27 PM
Ladsgroup mentioned this in rWDBR49976a4829d8: Make builder use gerrit instead of github for PropertySuggester.May 29 2017, 2:54 PM
gerritbot added a comment.May 29 2017, 5:55 PM

Change 355120 merged by jenkins-bot:
[wikidata/build-resources@master] Make builder use gerrit instead of github for PropertySuggester

https://gerrit.wikimedia.org/r/355120

Ladsgroup added a comment.May 29 2017, 9:57 PM

All patches are merged but some stuff need to be done before calling this done. I add a checklist at the task's description.

Ladsgroup updated the task description. (Show Details)May 29 2017, 9:58 PM
Ladsgroup moved this task from Review to Doing on the Wikidata-Former-Sprint-Board board.
Ladsgroup updated the task description. (Show Details)May 31 2017, 9:36 PM
Ladsgroup added a project: MediaWiki-extensions-PropertySuggester.May 31 2017, 10:39 PM
Ladsgroup updated the task description. (Show Details)
Addshore unsubscribed.Jun 7 2017, 10:13 AM
WMDE-leszek subscribed.Jun 8 2017, 8:15 AM

One possible thing to add to the checklist: stop L10n-bot doing updates on github, and make sure it only updates repo on Gerrit. Currently it seems updates are done two boths, which results in both repos diverge more and more :)

Ladsgroup added a comment.Jun 8 2017, 8:27 AM

@WMDE-leszek: Good catch. Made patch for that.

gerritbot added a comment.Jun 8 2017, 8:28 AM

Change 357771 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[translatewiki@master] Stop updating PropertySuggester in github.

https://gerrit.wikimedia.org/r/357771

Ladsgroup updated the task description. (Show Details)Jun 8 2017, 8:28 AM
gerritbot added a comment.Jun 8 2017, 8:53 AM

Change 357771 merged by jenkins-bot:
[translatewiki@master] Stop updating PropertySuggester in github.

https://gerrit.wikimedia.org/r/357771

Ladsgroup updated the task description. (Show Details)Jun 15 2017, 9:05 AM
Ladsgroup added a comment.Jun 15 2017, 9:09 AM

Okay, I closed the only one open PR in github: https://github.com/Wikidata-lib/PropertySuggester/pull/179

I don't think making it a redirect would be a good idea because we will lose lots of discussion that might be useful for future references.

Ladsgroup closed this task as Resolved.Jun 15 2017, 9:09 AM
Ladsgroup moved this task from Doing to Done on the Wikidata-Former-Sprint-Board board.
Liuxinyu970226 unsubscribed.Jun 15 2017, 9:12 AM
Lucas_Werkmeister_WMDE mentioned this in rEPS77ede9d5c39d: Remove Coveralls setup.Jul 2 2020, 2:18 PM
Ladsgroup mentioned this in rEPSe696f2fe97d8: Make jenkins pass on master.May 25 2023, 6:46 PM
Ladsgroup mentioned this in rEPSec8afc9aa01a: Add .gitreview.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits