Re: LDFLAGS broken?

From: Date: Thu, 23 Feb 2023 04:53:07 +0000
Subject: Re: LDFLAGS broken?
References: 1 2 3 4  Groups: php.internals 
Request: Send a blank email to [email protected] to get a copy of this message 
Hi!


There seems to be another unset done to this change here:
https://github.com/php/php-src/commit/c4d84aa33390045cd4ff542719a0f79cff52fb7c
which fixed some bugs related to linker errors and duplicate symbols.


Smells like people doing random things until some bug disappears...
and no commit messages here either, no explanation for the change.


Are you familiar with the principle called "Chesterton's fence"?

It could be these changes do not make sense. It also could be they are necessary for the build to work on one of dozens of systems, distros and tools combinations PHP is being built on. Unless you have tested on all of them, I'd advise caution there.

-- 
Stas Malyshev
[email protected]

Thread (8 messages)

« previous php.internals (#119597) next »