-
-
Notifications
You must be signed in to change notification settings - Fork 120
chore: set up ZENSTACK_TEST environment variable during test setup #1048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughWalkthroughThe recent updates involve modifications to the Jest configuration and test environment setup. The Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (8)
package.json
is excluded by:!**/*.json
packages/plugins/openapi/package.json
is excluded by:!**/*.json
packages/plugins/swr/package.json
is excluded by:!**/*.json
packages/plugins/tanstack-query/package.json
is excluded by:!**/*.json
packages/plugins/trpc/package.json
is excluded by:!**/*.json
packages/schema/package.json
is excluded by:!**/*.json
packages/server/package.json
is excluded by:!**/*.json
tests/integration/package.json
is excluded by:!**/*.json
Files selected for processing (3)
- jest.config.ts (1 hunks)
- script/set-test-env.ts (1 hunks)
- script/test-global-setup.ts (1 hunks)
Files skipped from review due to trivial changes (1)
- script/set-test-env.ts
Additional comments: 3
script/test-global-setup.ts (1)
- 5-5: The update to the file path for checking the existence of the
package-lock.json
file is a critical change for ensuring the script verifies the correct location. Please ensure that the new directory structure (.test/scaffold
) accurately reflects the intended organization for test scaffolds within the project.jest.config.ts (2)
- 12-12: The update to the
globalSetup
path is crucial for ensuring Jest uses the correct script for global setup before tests are run. This change appears to correctly point to the updated location of thetest-global-setup.ts
script. Ensure that the path accurately reflects the script's location within the project structure.- 14-14: The addition of a new entry in
setupFiles
to includeset-test-env.ts
is a significant enhancement for setting up the test environment. This change effectively ensures that theZENSTACK_TEST
environment variable is set before any tests are executed, which is essential for isolating test executions. Please verify that this script is correctly placed and functions as intended within the test setup process.
Closes #1020 |
Summary by CodeRabbit