Skip to content
This repository has been archived by the owner on Sep 21, 2021. It is now read-only.

reflect extraHosts of the hub container to node containers #186

Merged
merged 4 commits into from
Jul 25, 2017
Merged

reflect extraHosts of the hub container to node containers #186

merged 4 commits into from
Jul 25, 2017

Conversation

toshiya
Copy link
Contributor

@toshiya toshiya commented Jul 17, 2017

Add feature to reflect the extraHost setting of the hub container to node containers. (Discussed in the issue #182)

  • code changes are only for DockerContainerClient.java, not consider the case of using kubernetes
  • logic to read extraHosts from the hub is based on the existing getZaleniumNetwork

@codecov-io
Copy link

codecov-io commented Jul 17, 2017

Codecov Report

❗ No coverage uploaded for pull request base (issue-182@6ad8d07). Click here to learn what that means.
The diff coverage is 75%.

@@             Coverage Diff             @@
##             issue-182    #186   +/-   ##
===========================================
  Coverage             ?   69.3%           
  Complexity           ?     408           
===========================================
  Files                ?      26           
  Lines                ?    2049           
  Branches             ?     180           
===========================================
  Hits                 ?    1420           
  Misses               ?     537           
  Partials             ?      92

@diemol
Copy link
Contributor

diemol commented Jul 18, 2017

Hi @toshiya,

Thanks for this PR! I am on vacation now, I'll review it properly next week.

@diemol diemol changed the base branch from master to issue-182 July 25, 2017 11:41
@diemol
Copy link
Contributor

diemol commented Jul 25, 2017

Hi @toshiya,

I'll merge this to a branch so I can add some documentation and then I'll merge to master.

Thanks!

@diemol diemol merged commit af59b6c into zalando:issue-182 Jul 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants