Skip to content

chore: bump SWC to v23.2.0 and remove swc_parallel #10293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2025
Merged

Conversation

GiveMe-A-Name
Copy link
Member

@GiveMe-A-Name GiveMe-A-Name commented May 8, 2025

Summary

  • Updated SWC version from 21.0.0 to 22.0.0 in the root Cargo.toml. More detail about SWC changelog see: SWC CHANGELOG_CORE
  • Removed swc_parallel from multiple crates. We do not need to use swc_parallel to enable parallel feature. SWC export parallel feature in swc_core using parallel_rayon feature. So we remove swc_parallel crates.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

- Updated SWC version from 21.0.0 to 22.0.0 in the root Cargo.toml.
- Updated related SWC dependencies to their latest versions.
- Removed swc_parallel from multiple crates
Copy link

netlify bot commented May 8, 2025

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit 60d6b10
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/681c2395a2e915000800f7d9
😎 Deploy Preview https://deploy-preview-10293--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@GiveMe-A-Name GiveMe-A-Name marked this pull request as draft May 8, 2025 03:23
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label May 8, 2025
@GiveMe-A-Name GiveMe-A-Name marked this pull request as ready for review May 8, 2025 03:27
@GiveMe-A-Name GiveMe-A-Name requested a review from chenjiahan May 8, 2025 03:27
Copy link

codspeed-hq bot commented May 8, 2025

CodSpeed Performance Report

Merging #10293 will not alter performance

Comparing chore/bump-swc (60d6b10) with main (e7ab6e3)

Summary

✅ 11 untouched benchmarks

@chenjiahan chenjiahan requested a review from bvanjoi May 8, 2025 03:39
Copy link
Contributor

github-actions bot commented May 8, 2025

📝 Benchmark detail: Open

Name Base (2025-05-08 87ff236) Current Change
10000_big_production-mode_disable-minimize + exec 35.4 s ± 390 ms 36.1 s ± 743 ms +2.14 %
10000_development-mode + exec 1.82 s ± 50 ms 1.81 s ± 188 ms -0.45 %
10000_development-mode_hmr + exec 746 ms ± 16 ms 731 ms ± 18 ms -2.11 %
10000_production-mode + exec 2.28 s ± 38 ms 2.26 s ± 62 ms -0.73 %
10000_production-mode_persistent-cold + exec 2.46 s ± 41 ms 2.37 s ± 33 ms -3.40 %
10000_production-mode_persistent-hot + exec 1.74 s ± 45 ms 1.7 s ± 49 ms -2.55 %
arco-pro_development-mode + exec 1.78 s ± 99 ms 1.75 s ± 85 ms -2.16 %
arco-pro_development-mode_hmr + exec 382 ms ± 2.6 ms 381 ms ± 1.5 ms -0.06 %
arco-pro_production-mode + exec 3.43 s ± 53 ms 3.49 s ± 274 ms +1.55 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.61 s ± 305 ms 3.61 s ± 350 ms -0.08 %
arco-pro_production-mode_persistent-cold + exec 3.53 s ± 82 ms 3.49 s ± 144 ms -0.91 %
arco-pro_production-mode_persistent-hot + exec 2.19 s ± 77 ms 2.16 s ± 51 ms -1.16 %
arco-pro_production-mode_traverse-chunk-modules + exec 3.53 s ± 181 ms 3.46 s ± 86 ms -2.16 %
large-dyn-imports_development-mode + exec 2.05 s ± 64 ms 2 s ± 33 ms -2.23 %
large-dyn-imports_production-mode + exec 2.09 s ± 47 ms 2.08 s ± 133 ms -0.10 %
threejs_development-mode_10x + exec 1.68 s ± 161 ms 1.62 s ± 43 ms -3.57 %
threejs_development-mode_10x_hmr + exec 856 ms ± 9.4 ms 848 ms ± 14 ms -0.97 %
threejs_production-mode_10x + exec 5.28 s ± 242 ms 5.22 s ± 330 ms -1.09 %
threejs_production-mode_10x_persistent-cold + exec 5.29 s ± 49 ms 5.23 s ± 56 ms -1.20 %
threejs_production-mode_10x_persistent-hot + exec 4.47 s ± 22 ms 4.39 s ± 26 ms -1.67 %
10000_big_production-mode_disable-minimize + rss memory 9317 MiB ± 283 MiB 9184 MiB ± 181 MiB -1.42 %
10000_development-mode + rss memory 641 MiB ± 18.6 MiB 649 MiB ± 15.3 MiB +1.30 %
10000_development-mode_hmr + rss memory 785 MiB ± 13.5 MiB 775 MiB ± 13.3 MiB -1.24 %
10000_production-mode + rss memory 658 MiB ± 42.6 MiB 653 MiB ± 17.2 MiB -0.66 %
10000_production-mode_persistent-cold + rss memory 752 MiB ± 75.7 MiB 751 MiB ± 19.4 MiB -0.11 %
10000_production-mode_persistent-hot + rss memory 749 MiB ± 76.5 MiB 762 MiB ± 45.5 MiB +1.74 %
arco-pro_development-mode + rss memory 577 MiB ± 55.9 MiB 587 MiB ± 65.5 MiB +1.76 %
arco-pro_development-mode_hmr + rss memory 486 MiB ± 40.9 MiB 495 MiB ± 39 MiB +1.71 %
arco-pro_production-mode + rss memory 652 MiB ± 73.1 MiB 684 MiB ± 58.1 MiB +4.87 %
arco-pro_production-mode_generate-package-json-webpack-plugin + rss memory 702 MiB ± 64.2 MiB 697 MiB ± 88.9 MiB -0.66 %
arco-pro_production-mode_persistent-cold + rss memory 785 MiB ± 54.3 MiB 793 MiB ± 60.4 MiB +0.94 %
arco-pro_production-mode_persistent-hot + rss memory 656 MiB ± 80.2 MiB 652 MiB ± 64.5 MiB -0.64 %
arco-pro_production-mode_traverse-chunk-modules + rss memory 693 MiB ± 54.1 MiB 717 MiB ± 52.2 MiB +3.43 %
large-dyn-imports_development-mode + rss memory 650 MiB ± 2.72 MiB 651 MiB ± 6.34 MiB +0.17 %
large-dyn-imports_production-mode + rss memory 535 MiB ± 4.07 MiB 537 MiB ± 4.7 MiB +0.23 %
threejs_development-mode_10x + rss memory 603 MiB ± 20.4 MiB 610 MiB ± 26.2 MiB +1.15 %
threejs_development-mode_10x_hmr + rss memory 728 MiB ± 23.8 MiB 721 MiB ± 16.9 MiB -1.04 %
threejs_production-mode_10x + rss memory 934 MiB ± 38.7 MiB 912 MiB ± 110 MiB -2.37 %
threejs_production-mode_10x_persistent-cold + rss memory 1001 MiB ± 49.4 MiB 998 MiB ± 111 MiB -0.25 %
threejs_production-mode_10x_persistent-hot + rss memory 903 MiB ± 29.3 MiB 880 MiB ± 35.9 MiB -2.56 %

@chenjiahan chenjiahan merged commit 0ed2193 into main May 10, 2025
58 of 61 checks passed
@chenjiahan chenjiahan deleted the chore/bump-swc branch May 10, 2025 01:59
github-merge-queue bot pushed a commit to lynx-family/lynx-stack that referenced this pull request May 15, 2025
<!--
  Thank you for submitting a pull request!

We appreciate the time and effort you have invested in making these
changes. Please ensure that you provide enough information to allow
others to review your pull request.

Upon submission, your pull request will be automatically assigned with
reviewers.

If you want to learn more about contributing to this project, please
visit:
https://github.com/lynx-family/lynx-stack/blob/main/CONTRIBUTING.md.
-->

## Summary

<!-- Can you explain the reasoning behind implementing this change? What
problem or issue does this pull request resolve? -->

<!-- It would be helpful if you could provide any relevant context, such
as GitHub issues or related discussions. -->

Rust 1.81.0 will crash due to the updated dependency `sourcemap` using
`iter::repeat_n()`, so we need to upgrade to 1.86.0.

See:
- web-infra-dev/rspack#10293
- rust-lang/rust#104434

## Checklist

<!--- Check and mark with an "x" -->

- [x] Tests updated (or not required).
- [x] Documentation updated (or not required).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants