RTCPeerConnectionState and RTCIceConnectionState computation should consider sctp transport #2680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onsider sctp transport
|
Fixes #2677 |
|
Needs to refer to all 3 usages of "set of transports", otherwise LGTM. |
|
Doesn't SCTP run on top of ice? |
jan-ivar
approved these changes
Oct 7, 2021
it does, but we do have the option of either using the same transport or a different transport. |
|
for record keeping, this was merged under the "pure bug fix" category of https://github.com/w3c/webrtc-charter/blob/gh-pages/merge-guide.md#changes-that-bypass-the--extensions-stage, correct? |
dontcallmedom
added a commit
that referenced
this pull request
Jan 28, 2022
Candidate amendments process: https://www.w3.org/2021/Process-20211102/#candidate-changes PR covered based on https://github.com/w3c/webrtc-pc/pulls?q=is%3Apr++-label%3AEditorial+merged%3A%3E2021-01-01+ (merged PRs since Jan 1 2021): #2679 #2680 #2686 #2687 #2689 #2691 #2700 #2704 #2708
dontcallmedom
added a commit
that referenced
this pull request
May 5, 2022
Candidate amendments process: https://www.w3.org/2021/Process-20211102/#candidate-changes PR covered based on https://github.com/w3c/webrtc-pc/pulls?q=is%3Apr++-label%3AEditorial+merged%3A%3E2021-01-01+ (merged PRs since Jan 1 2021): #2679 #2680 #2686 #2687 #2689 #2691 #2700 #2704 #2708
dontcallmedom
added a commit
that referenced
this pull request
Jul 19, 2022
Candidate amendments process: https://www.w3.org/2021/Process-20211102/#candidate-changes PR covered based on https://github.com/w3c/webrtc-pc/pulls?q=is%3Apr++-label%3AEditorial+merged%3A%3E2021-01-01+ (merged PRs since Jan 1 2021): #2679 #2680 #2686 #2687 #2689 #2691 #2700 #2704 #2708
dontcallmedom
added a commit
that referenced
this pull request
Aug 19, 2022
Candidate amendments process: https://www.w3.org/2021/Process-20211102/#candidate-changes PR covered based on https://github.com/w3c/webrtc-pc/pulls?q=is%3Apr++-label%3AEditorial+merged%3A%3E2021-01-01+ (merged PRs since Jan 1 2021): #2679 #2680 #2686 #2687 #2689 #2691 #2700 #2704 #2708
dontcallmedom
added a commit
that referenced
this pull request
Sep 27, 2022
Candidate amendments process: https://www.w3.org/2021/Process-20211102/#candidate-changes PR covered based on https://github.com/w3c/webrtc-pc/pulls?q=is%3Apr++-label%3AEditorial+merged%3A%3E2021-01-01+ (merged PRs since Jan 1 2021): #2679 #2680 #2686 #2687 #2689 #2691 #2700 #2704 #2708
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview | Diff