-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-scroll-snap] scroll-snap-align values assigned backwards #2232
Comments
Filed Chromium issue to fix this before we ship. However Safari is shipping the scroll-snap-align with inline/block order so there is interop risk here. Is there any indication that they will switch as well? otherwise we need to evaluate the interop risk here. |
Originally posted here. I ran a query against httparchive database to better understand the compat risk. My exact query is below if anyone wants to replicate [1]. Only 4 were using the scroll-snap-align with two arguments. This is out of 450k pages so usage and breakage is very low AFAICT. This gives me more confidence to make the switch. We should ensure Safari is willing to make the switch to avoid interop issues. Here is the result:
Note that one of the cases is actually using it incorrectly. [1] BigQuery query:
|
@smfr do you have any opinion on this change one way or another? It seems a safe change to me so I plan to match the spec in Chromium implementation. |
FWIW, I filed a webkit bug since Safari is still shipping the old ordering: |
I've also added a note to the MDN docs for scroll-snap-align |
We decided that the first keyword should affect the block axis, the second the inline axis: and defined it correctly for the place-* shorthands of the alignment properties, but seem to have specified it backwards for css-scroll-snap. :(
The text was updated successfully, but these errors were encountered: