ST4114 incompatibility #213
Comments
rchl
added a commit
to rchl/vue-syntax-highlight
that referenced
this issue
Sep 4, 2021
A non-backward compatible change was introduced in updated HTML syntax that breaks loading of Vue syntax. This removes context that references removed variable `script_close_lookahead`. There is supposedly no point to overriding it in the first places since there is no custom syntax introduced here. Fixes vuejs#213
skyronic
pushed a commit
that referenced
this issue
Sep 9, 2021
Fixes #213 This commit applies the required patch of ST4114's HTML.sublime-syntax in order to fix VUE's incompatibility with most recent ST, while maintaining backward compatibility with older builds. The relevant contexts are overridden and variables are copied over from HTML.sublime-syntax. Note: The `style-close-tag` was probably not needed, as it hasn't changed, but it is copied to maintain formal consistency with script tags.
|
Can be closed now? Thanks for fixing it @deathaxe btw! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ST's HTML syntax had to change the way how CSS/JS syntax definitions are embedded within style and script tags in order to fix a core bug. It also requires changes to how those syntaxes are to be embedded. This change unfortunatelly effects all syntaxes, which inherit HTML.
Related PR: sublimehq/Packages#2831
This broke VUE syntax.
A short look at this package revealed the following lines to be obsolete or not needed at all.
vue-syntax-highlight/Vue Component.sublime-syntax
Lines 191 to 195 in 6c3c26d
A backward compatible fix was to remove the context.
An inherited syntax needs to override
script-javascript-contentorstyle-css-contentonly, if it wants to embed a custom CSS/JS syntax (or scope), which is not the case here.I'd suggest to take a look at...
https://github.com/sublimehq/Packages/blob/c70117be6402c54ccf860ab8edfcba8aade46c9e/ASP/HTML%20(ASP).sublime-syntax#L37-L67
This approach might be needed for all kinds of embedded script syntaxes to ensure toggle comment is working on the first and last line properly.
The text was updated successfully, but these errors were encountered: