Skip to content

Align Range v-for HTML sample with actual result #904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2017

Conversation

Pacoup
Copy link
Contributor

@Pacoup Pacoup commented May 12, 2017

In the Range v-for example, the result is printed with spaces. This is confusing because the sample HTML does not have additional spaces. In fact, when I saw this, I thought Vue was adding a space on its own, which I immediately verified because I thought that would be a very unintuitive and potentially problematic behavior.

Fortunately, Vue does behave as expected. The problem is merely that the HTML sample in the documentation is not the same as the markup of the actual Vue code in the example.

This PR corrects this by adding the space before the closing </span>.

Alternatively, the space could be removed in the example code instead, but personally, I think this way is better because it illustrates a specific behavior with spaces.

@chrisvfritz
Copy link
Contributor

Nice catch!

@chrisvfritz chrisvfritz merged commit ea5356a into vuejs:master May 19, 2017
kazupon pushed a commit to kazupon/vuejs.org that referenced this pull request Oct 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants