Set the default color for the search input #516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the search input text color is not set, if a user has changed its default color (ie. when using a dark theme), then the search input text can be unreadable.
chrisvfritz
approved these changes
Oct 18, 2016
dingyiming
added a commit
to volksbright/document-standard-vue
that referenced
this pull request
Oct 20, 2016
* master: Remove possible fulltime statement and re-arange business part (vuejs#520) Fix an error in Component Example (vuejs#521) update component inline-template (vuejs#519) wrong id (typo) (vuejs#515) Set the default color for the search input (vuejs#516) fix link to single-file-components.html (vuejs#514) fix broken link to contributing guide, fixes vuejs#513 # Conflicts: # src/guide/index.md # src/guide/join.md # src/support-vuejs/index.md
Peter-WF
pushed a commit
to Peter-WF/vuefe.github.io
that referenced
this pull request
Nov 18, 2016
* Set the default color for the search input Since the search input text color is not set, if a user has changed its default color (ie. when using a dark theme), then the search input text can be unreadable. * Update search color to $dark
Peter-WF
pushed a commit
to Peter-WF/vuefe.github.io
that referenced
this pull request
Nov 18, 2016
* master: Remove possible fulltime statement and re-arange business part (vuejs#520) Fix an error in Component Example (vuejs#521) update component inline-template (vuejs#519) wrong id (typo) (vuejs#515) Set the default color for the search input (vuejs#516) fix link to single-file-components.html (vuejs#514) fix broken link to contributing guide, fixes vuejs#513 # Conflicts: # src/guide/index.md # src/guide/join.md # src/support-vuejs/index.md
kazupon
pushed a commit
to kazupon/vuejs.org
that referenced
this pull request
Oct 1, 2017
* Set the default color for the search input Since the search input text color is not set, if a user has changed its default color (ie. when using a dark theme), then the search input text can be unreadable. * Update search color to $dark
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the search input text color is not set, if a user has changed its default color (ie. when using a dark theme), then the search input text can be unreadable.
Example of hard to read color combination:
This PR just sets the color to a default one.