Skip to content

[arb-mod] add Arabic subtitles for "why vue" video #1808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Feb 18, 2019

Conversation

chadidi
Copy link
Contributor

@chadidi chadidi commented Sep 23, 2018

This is the Arabic translation, but needs some review from message 17 and up cause it was translated with google translation, I just had the time to review the first 40 seconds.

any help appreciated

@sdras
Copy link
Member

sdras commented Oct 8, 2018

Thank you! I will ask around for help on the review here and get back to you when we have someone.

@Ma7eer
Copy link

Ma7eer commented Oct 9, 2018

Hello I added some comments but before I continue and make a mess was wondering if this is the type of thing you were looking for? or do you want me to "start a review"?

Guess my question is are you looking for comment? or actually going in and changing the content? Willing to do either!

@sdras
Copy link
Member

sdras commented Oct 9, 2018

From my understanding, I think it would be ok to go change the content, but @chadidi please correct me if I'm mistaken

@dtheb
Copy link

dtheb commented Oct 9, 2018

What's the main goal of the review? understanding (tech scene dialect) or grammars/classical Arabic?
Because these 2 styles can't really co-exist 😞

@chadidi
Copy link
Contributor Author

chadidi commented Oct 9, 2018

@Ma7eer it's gonna be nice from your part if you can fix this translation.

@sdras exactly, I am not very good with translations.

@dtheb the goal is to translate this script to "Modern Standard Arabic".

Thanks.

@meabed
Copy link

meabed commented Oct 10, 2018

@HashemKhalifa could you have a look?

@AhmedAbdulrahman
Copy link

Well, it's a bit challenging to translate technical terms from English into Arabic and not easy to apply common translation standards for Arabic, you may find three or more different translations for the same source piece of text. I think It would be better if you provide some explanation alongside translation for complex terms. @sdras

@AhmedHelalAhmed
Copy link

i can contribute

@chadidi
Copy link
Contributor Author

chadidi commented Oct 10, 2018

@AhmedAbdulrahman The goal is that for people who don't understand English to understand the video from the Arabic subtitles that we are working on, and for the technical terms mostly javascript it doesn't matter if it translated or not most people that are going to watch this video are developers or learning development and there is a high chance that they already know this terms.

@chadidi
Copy link
Contributor Author

chadidi commented Oct 10, 2018

@AhmedHelalAhmed @Ma7eer @dtheb @meabed @abdumu We have this public community on transifex maybe it's going to be easier on you guys to translate and review this file their https://www.transifex.com/laravelarab/public/

is that ok @sdras

Thanks

@sdras
Copy link
Member

sdras commented Oct 10, 2018

Perfect. Thank you @chadidi! I'll be honest, I'm a bit at a loss because I don't know Arabic, but please ping me on this PR when you all feel like it's in a good place and I will merge it in. Thank you!

@sdras
Copy link
Member

sdras commented Nov 1, 2018

Hey @chadidi @AhmedHelalAhmed @Ma7eer @dtheb @meabed @abdumu, how is this coming? No worries if you need more time, just checking in.

Copy link

@abdumu abdumu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@abdumu abdumu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revised.

@chadidi
Copy link
Contributor Author

chadidi commented Nov 8, 2018

Hey @AhmedHelalAhmed @Ma7eer @dtheb @meabed @abdumu can you guys check the translation one last time, and if you can try it with the video also.

Thanks

@chadidi
Copy link
Contributor Author

chadidi commented Nov 13, 2018

Hey @sdras, I think this PR is ready to merge.

@sdras
Copy link
Member

sdras commented Feb 18, 2019

Ok thank you!

@sdras sdras merged commit 93634d7 into vuejs:master Feb 18, 2019
phanan pushed a commit to phanan-forks/vuejs.org that referenced this pull request Mar 20, 2019
* Translate 13 seconds of the presentation video to arabic

* Translated with google translator and need review from message 17 and up

* first review from 1 to 16

* Update assets/why-vue/arabic.js.srt

Co-Authored-By: chadidi <[email protected]>

* Update line 45

Co-Authored-By: chadidi <[email protected]>

* Update line 46

Co-Authored-By: chadidi <[email protected]>

* Update translation from line 1 to 51

* Update line 79

Co-Authored-By: chadidi <[email protected]>

* Update translation from line 52 to 102

* Update line 114

Co-Authored-By: chadidi <[email protected]>

* Update translation from line 103 to 163

* Update line 171

Co-Authored-By: chadidi <[email protected]>

* Update line 211

Co-Authored-By: chadidi <[email protected]>

* Update translation from line 164 to 266

* Update line 274

Co-Authored-By: chadidi <[email protected]>

* Update line 294

Co-Authored-By: chadidi <[email protected]>

* Update line 298

Co-Authored-By: chadidi <[email protected]>

* Update line 314

Co-Authored-By: chadidi <[email protected]>

* Update line 290

Co-Authored-By: chadidi <[email protected]>

* Update line 342

Co-Authored-By: chadidi <[email protected]>

* Update line 374

Co-Authored-By: chadidi <[email protected]>

* Update line 402

Co-Authored-By: chadidi <[email protected]>

* Update translation from line 267 to 418

* Update line 462

Co-Authored-By: chadidi <[email protected]>

* Update translation from line 419 to 587
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants