Skip to content

Proposition ~ environments: vuex, vue-router #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
armano2 opened this issue Jul 20, 2017 · 3 comments
Closed

Proposition ~ environments: vuex, vue-router #102

armano2 opened this issue Jul 20, 2017 · 3 comments
Labels

Comments

@armano2
Copy link
Contributor

armano2 commented Jul 20, 2017

I was thinking a little how to allow/disallow functions from official plugins vuex and vue-route, and i don't want to add by default rules to tell that names are reserved, or you can use this component etc....
I think we need some sort of flags to disable/enable official plugin support. If its possible in similar way as Environments are set up in eslint.

By default support both of plugins should be enabled but optionally user will be able to disable them.

Let me know what do you think about this

@armano2 armano2 changed the title Proposition: Environments: vuex, vue-router Proposition ~ environments: vuex, vue-router Jul 20, 2017
@michalsnik
Copy link
Member

I think this is a really interesting idea and we should definitely investigate it, though @mysticatea might already have better insights based on his work in eslint organization. Plugins like vuex and vue-router are totally optional, thus I'd prefer not to add this in the recommend config but make it possible for the users to add those themselves when needed.

@mysticatea
Copy link
Member

I'm sorry for late.
We are using settings: http://eslint.org/docs/user-guide/configuring#adding-shared-settings

For example:

{
    "extends": ["eslint:recommended", "plugin:vue/recommended"],
    "settings": {
        "vue": {
            "env": {
                "vuex": true,
                "vue-route": true
            }
        }
    }
}

@michalsnik
Copy link
Member

Cool @mysticatea , then I think we can close this issue @armano2. Seems like we have an option and it just needs to be implemented on a specific rule if needed, there is no other work to be done in order to configure it apart from adding default values in base config and documenting it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants