Skip to content

#65: New Vuejs.org Theme #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 6, 2020
Merged

#65: New Vuejs.org Theme #98

merged 11 commits into from
Jul 6, 2020

Conversation

bencodezen
Copy link
Member

@bencodezen bencodezen commented May 21, 2020

Disclaimer: Most of this PR's file changes are just a straight copy and paste of the original VuePress theme. I would look past the initial commit d098202 for what actually changed from the default VuePress theme

It is far from perfect. I had high hopes of accomplishing things such as:

  • Solid CSS architecture
  • Migrating all styles to Sass
  • Refactoring the styles to be easily extensible

Rather than hold this up any longer. I've made some incremental improvements that get us 80% of the way there as far as the end user is concerned and I figured we can build from here.

Copy link
Member

@sdras sdras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yayyyy

@bencodezen bencodezen self-assigned this Jul 3, 2020
@bencodezen bencodezen mentioned this pull request Jul 6, 2020
25 tasks
@bencodezen bencodezen merged commit ada000a into master Jul 6, 2020
@NataliaTepluhina NataliaTepluhina deleted the feature/65-vuejs-org-theme branch July 17, 2020 14:40
TalexDreamSoul pushed a commit to Talexs/docs that referenced this pull request Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants