Skip to content

Built-in components API #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 21, 2020
Merged

Built-in components API #96

merged 5 commits into from
Jun 21, 2020

Conversation

NataliaTepluhina
Copy link
Member

@NataliaTepluhina NataliaTepluhina commented May 14, 2020 •
edited
Loading

Please note than transitions in the description lack appear hooks. I will add them as soon as vuejs/core#1175 is merged

@NataliaTepluhina NataliaTepluhina changed the title [WIP]Built-in components API [WIP] Built-in components API May 15, 2020
@NataliaTepluhina NataliaTepluhina self-assigned this May 15, 2020
@NataliaTepluhina NataliaTepluhina added content Issues / PRs related to docs content enhancement New feature or request state: blocked A label for merge requests where work is blocked labels May 15, 2020
@NataliaTepluhina NataliaTepluhina marked this pull request as ready for review May 15, 2020 06:37
@NataliaTepluhina NataliaTepluhina changed the title [WIP] Built-in components API Built-in components API May 15, 2020
@NataliaTepluhina NataliaTepluhina removed the state: blocked A label for merge requests where work is blocked label Jun 18, 2020
@NataliaTepluhina
Copy link
Member Author

Also, this PR lacks <teleport> API (to be added in the next iteration)

phanan
phanan approved these changes Jun 18, 2020
View reviewed changes
Copy link
Member

@phanan phanan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice work! I've added a minor feedback and a suggestion.

@NataliaTepluhina NataliaTepluhina merged commit 28e8074 into master Jun 21, 2020
@NataliaTepluhina NataliaTepluhina deleted the special-components branch July 15, 2020 09:15
TalexDreamSoul pushed a commit to Talexs/docs that referenced this pull request Apr 17, 2022
@kaijia323 @wxsms @veaba
docs(provide-inject): src/guide/components/provide-inject.md vuejs#94 (…
beb2f0e 
…vuejs#96)

* docs: Add node version description

* Update README.md

* docs(provide-inject): src/guide/components/provide-inject.md vuejs#94

* docs(provide-inject): update, no space between Chinese and English

* Apply suggestions from code review

Co-authored-by: wangguofeng <[email protected]>
Co-authored-by: wxsm <[email protected]>
Co-authored-by: Godpu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phanan phanan phanan approved these changes

@bencodezen bencodezen Awaiting requested review from bencodezen

@Jinjiang Jinjiang Awaiting requested review from Jinjiang

@pikax pikax Awaiting requested review from pikax

@sdras sdras Awaiting requested review from sdras

@znck znck Awaiting requested review from znck

Assignees

@NataliaTepluhina NataliaTepluhina

Labels
content Issues / PRs related to docs content enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NataliaTepluhina @phanan