Migrate: State management #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phanan
commented
May 12, 2020
phanan
commented
May 12, 2020
There was a problem hiding this comment.
@phanan Thank you for migrating this! I've added a few comments for your consideration
Co-authored-by: Natalia Tepluhina <[email protected]>
Co-authored-by: Natalia Tepluhina <[email protected]>
Co-authored-by: Natalia Tepluhina <[email protected]>
Co-authored-by: Natalia Tepluhina <[email protected]>
NataliaTepluhina
approved these changes
May 12, 2020
There was a problem hiding this comment.
@phanan whoa, those were super fast fixes 😅
Looks good to me! 👍
bencodezen
reviewed
May 13, 2020
|
|
||
|  | ||
|
|
||
| ::: tip |
There was a problem hiding this comment.
Suggested change
| ::: tip | |
| ::: danger |
There was a problem hiding this comment.
The original type for this message on vuejs.org is "success." I don't think it's a "dangerous" action per-se, more like a tip (hence "Tip"). TBH I'm tempted to blend this "tip" into the content altogether and avoid the flow breakage. WDYT?
TalexDreamSoul
pushed a commit
to Talexs/docs
that referenced
this pull request
Apr 17, 2022
…vuejs#96) * docs: Add node version description * Update README.md * docs(provide-inject): src/guide/components/provide-inject.md vuejs#94 * docs(provide-inject): update, no space between Chinese and English * Apply suggestions from code review Co-authored-by: wangguofeng <[email protected]> Co-authored-by: wxsm <[email protected]> Co-authored-by: Godpu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview: https://deploy-preview-94--vue-docs-next-preview.netlify.app/guide/state-management.html