feat: add carbon ads #724
Merged
feat: add carbon ads #724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
posva
commented
Dec 2, 2020
| <style> | ||
| /* add a placeholder to give space to ads so they don't overlap with content */ | ||
| @media screen and (max-width: 1376px) { | ||
| .content__default::before { |
There was a problem hiding this comment.
This to make the ad take some space
vuejs.org, ad inside content
vuepress doesn't:
But it creates overlap for tip containers unless we add overflow-x: auto but that breaks the icon display:
Which is the reason I added the background
posva
commented
Dec 2, 2020
| @@ -77,7 +97,7 @@ export default { | |||
| ) | |||
| }, | |||
|
|
|||
| shouldShowSidebar () { | |||
| shouldShowSidebar() { | |||
There was a problem hiding this comment.
Apparently other functions are also following this convention. I simply forgot to turn off auto format when saving but I can revert these changes
|
@posva looks really nice! Should we remove the |
NataliaTepluhina
approved these changes
Dec 5, 2020
|
Is the background solution satisfactory enough? |
|
@posva I think it's justified to be hacky 😅 |
|
Okay, I thought the same 😅 |
fimion
pushed a commit
to fimion/docs-next
that referenced
this pull request
Dec 21, 2020
* feat: add carbon ads * refactor: add computed * refactor: background for style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Problem
Proposed Solution
Additional Information
Closes #30
I couldn't test locally because the
servescript fails right awayThere are a few necessary changes left to be done to display the ads correctly and mimic vuejs.org