Rough Draft of New Reactivity Section #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forgot to mention, as per our earlier conversations, I added a small thing into the writing guide about how scoping down PRs. The irony does not escape me. |
There was a problem hiding this comment.
Thank you for this nice and dedicated PR, @sdras! It's an awesome explanation of Proxies-based reactivity 👍
I've left a few notes to discuss 😅
yyx990803
reviewed
Apr 7, 2020
Co-Authored-By: Evan You <[email protected]>
Co-Authored-By: Evan You <[email protected]>
Co-Authored-By: Natalia Tepluhina <[email protected]>
Co-Authored-By: Natalia Tepluhina <[email protected]>
bencodezen
reviewed
Apr 9, 2020
There was a problem hiding this comment.
Great job with this @sdras! Just added some minor things I noticed going through it.
|
Thanks for the feedback! Ok, this should be in a better state now for merging. In subsequent PRs, we will address:
Let me know if you need further changes on this that don't apply to those two pieces! Thanks! |
bencodezen
approved these changes
Apr 27, 2020
Co-Authored-By: Ben Hong <[email protected]>
Co-Authored-By: Ben Hong <[email protected]>
Co-Authored-By: Ben Hong <[email protected]>
TalexDreamSoul
pushed a commit
to Talexs/docs
that referenced
this pull request
Apr 17, 2022
* integrate zhlint into scripts * add zhlint as a dev dep * upgrade zhlint
moHaHa
pushed a commit
to moHaHa/vuejs-docs
that referenced
this pull request
May 4, 2023
translate components/v-model components/attrs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a rough draft of a new revised Reactivity section. Previously we got some feedback that the Reactivity Section wasn't so clear and was a little opaque. I've broken down concepts a bit more to ramp folks up to things they might not be familiar with.
Here's what the PR includes:
What's left to do:
data-linehighlighting on the code samples so folks can see at a glance what's changedOpen to feedback!