Replaced first example in Introduction #343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice job on this @NataliaTepluhina! Do you think it would be worth adding a pause / resume button on the example since it technically run infinitely? And to be clear, I don't think we should add it to the code snippet itself, but just on the rendered version as a UX enhancement. |
bencodezen
approved these changes
Jul 27, 2020
There was a problem hiding this comment.
@NataliaTepluhina Also, I'm happy to work on that piece if you want. Just thought I'd mention it, but otherwise looks great!
|
Thanks @bencodezen! Makes sense to me, will add a button 👍🏻 |
|
@bencodezen fix applied! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the reasoning in #253, I've replaced the first example with Vue component with a reactive property changing over time. I'm still not sure if it's the best decision so would be open to hearing your opinions
Close #253