Skip to content

Move non-prop attributes to a separate section #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 26, 2020

Conversation

NataliaTepluhina
Copy link
Member

In this PR:

  • We add a short mention of emits to Component Basics
  • We move non-prop attributes to a separate section in Component In-Depth

@NataliaTepluhina NataliaTepluhina added the enhancement New feature or request label Jul 25, 2020
@NataliaTepluhina NataliaTepluhina self-assigned this Jul 25, 2020
@NataliaTepluhina NataliaTepluhina linked an issue Jul 25, 2020 that may be closed by this pull request
Copy link
Member

@sdras sdras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Couple minor suggestions left here and there.

console.log(this.$attrs) // { onChange: () => {} }
}
})
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might benefit from an example that people can use

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added! 👍🏻

props: ['title'],
emits: ['enlarge-text']
})
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be good to explain why this is useful, i.e. being explicit to maintainers

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a note on emitted events validation 👍🏻

@NataliaTepluhina
Copy link
Member Author

@sdras thank you for the super valuable comments! 👍🏻 I've updated the PR, could you please take a brief look over changes?

@NataliaTepluhina NataliaTepluhina requested a review from sdras July 26, 2020 11:34
Copy link
Member

@sdras sdras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@sdras sdras merged commit b14a634 into master Jul 26, 2020
@sdras sdras deleted the move-non-prop-attributes branch July 26, 2020 16:40
@sdras
Copy link
Member

sdras commented Jul 26, 2020

Thanks Natalia!

alexeyvokin pushed a commit to alexeyvokin/docs-ru_old that referenced this pull request Apr 1, 2024
* Перевод страницы Sponsors

* fix Теперь в заголовках слова не начинаются с больших букв
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Non-props attributes to the separate section in docs
2 participants