-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Move non-prop attributes to a separate section #340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Couple minor suggestions left here and there.
console.log(this.$attrs) // { onChange: () => {} } | ||
} | ||
}) | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might benefit from an example that people can use
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added! 👍🏻
props: ['title'], | ||
emits: ['enlarge-text'] | ||
}) | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be good to explain why this is useful, i.e. being explicit to maintainers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a note on emitted events validation 👍🏻
@sdras thank you for the super valuable comments! 👍🏻 I've updated the PR, could you please take a brief look over changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Thanks Natalia! |
* Перевод страницы Sponsors * fix Теперь в заголовках слова не начинаются с больших букв
In this PR:
emits
to Component Basics