-
Notifications
You must be signed in to change notification settings - Fork 4.7k
TypeScript section #339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeScript section #339
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor things, well done 👍
Co-authored-by: Carlos Rodrigues <[email protected]>
…typescript-support
Co-authored-by: Carlos Rodrigues <[email protected]>
…typescript-support
@pikax thank you for all the invaluable suggestions! I've applied fixes, could you please take a second look? 🙏🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, few more comments :)
Co-authored-by: Carlos Rodrigues <[email protected]>
@pikax thank you! Applied more fixes and there is still one question remaining. Back to you ⚽ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great, thanks for all your work on it! Just a few small nits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Co-authored-by: Carlos Rodrigues <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice to see this.
There is a way for simplify the typing of complex type ?
Instead of Object as PropType<T>
we could have a JS object with similar but typable, with a function Prop<T>()
.
What do you think @NataliaTepluhina
let count = ref(0) | ||
|
||
// read-only | ||
const double = computed(() => count.value) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compute a value without any change is IMHO a little too simply..
@NataliaTepluhina did you see my comment ? |
* Перевод страницы Releases * fix Исправление ошибок по ревью * Update releases.md --------- Co-authored-by: Bochkarev Ivan <[email protected]>
This is a raw draft of a TypeScript section