Skip to content

TypeScript section #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Jul 27, 2020
Merged

TypeScript section #339

merged 25 commits into from
Jul 27, 2020

Conversation

NataliaTepluhina
Copy link
Member

This is a raw draft of a TypeScript section

@NataliaTepluhina NataliaTepluhina self-assigned this Jul 25, 2020
@NataliaTepluhina NataliaTepluhina added content Issues / PRs related to docs content enhancement New feature or request labels Jul 25, 2020
@NataliaTepluhina NataliaTepluhina linked an issue Jul 25, 2020 that may be closed by this pull request
@NataliaTepluhina NataliaTepluhina requested a review from pikax July 25, 2020 14:14
Copy link
Member

@pikax pikax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor things, well done 👍

@NataliaTepluhina
Copy link
Member Author

@pikax thank you for all the invaluable suggestions! I've applied fixes, could you please take a second look? 🙏🏻

@NataliaTepluhina NataliaTepluhina requested a review from pikax July 25, 2020 16:15
Copy link
Member

@pikax pikax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, few more comments :)

@NataliaTepluhina
Copy link
Member Author

@pikax thank you! Applied more fixes and there is still one question remaining. Back to you ⚽

@NataliaTepluhina NataliaTepluhina requested a review from pikax July 26, 2020 11:12
@NataliaTepluhina NataliaTepluhina marked this pull request as ready for review July 26, 2020 14:51
Copy link
Member

@sdras sdras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great, thanks for all your work on it! Just a few small nits.

@NataliaTepluhina NataliaTepluhina requested a review from pikax July 27, 2020 12:47
Copy link
Member

@pikax pikax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@NataliaTepluhina NataliaTepluhina merged commit ae5c772 into master Jul 27, 2020
Copy link
Contributor

@edimitchel edimitchel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice to see this.
There is a way for simplify the typing of complex type ?
Instead of Object as PropType<T> we could have a JS object with similar but typable, with a function Prop<T>().
What do you think @NataliaTepluhina

let count = ref(0)

// read-only
const double = computed(() => count.value)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compute a value without any change is IMHO a little too simply..

@edimitchel
Copy link
Contributor

@NataliaTepluhina did you see my comment ?

@NataliaTepluhina NataliaTepluhina deleted the typescript-support branch August 3, 2020 04:41
alexeyvokin pushed a commit to alexeyvokin/docs-ru_old that referenced this pull request Apr 1, 2024
* Перевод страницы Releases

* fix Исправление ошибок по ревью

* Update releases.md

---------

Co-authored-by: Bochkarev Ivan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Issues / PRs related to docs content enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a section dedicated to TypeScript usage with Vue 3
4 participants