Reword preference of Vue Testing Library over Vue Test Utils #330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmiller1990
reviewed
Jul 23, 2020
src/guide/testing.md
Outdated
| @@ -86,7 +86,7 @@ Its guiding principle is that the more tests resemble the way software is used, | |||
|
|
|||
| #### Vue Test Utils | |||
|
|
|||
| Vue Test Utils is the low-level component testing library that was written to provide users access to Vue specific APIs. While it is officially maintained, we recommend most users use Vue Testing Library, which is an abstraction over Vue Test Utils. | |||
| Vue Test Utils is the official low-level component testing library that was written to provide users access to Vue specific APIs. If you are starting testing Vue applications, we would recommend using Vue Testing Library, which is an abstraction over Vue Test Utils. | |||
There was a problem hiding this comment.
Should this be "If you are new to testing" or "If you are starting a new application"?
I like the testing library philosophy more, but I like the VTU API more 😱 that said I don't mind which library is used, as long as people are testing their apps 👍
There was a problem hiding this comment.
fixed! thanks. copy&paste went wrong 😇
dobromir-hristov
approved these changes
Jul 23, 2020
bencodezen
approved these changes
Jul 23, 2020
|
I believe we have a coon consensus here 😅 Thanks @afontcu for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to clarify the statement where the official docs recommend Vue Testing Library over Vue Test Utils (the official library).
When developing the new version of VTU, we wanted to frame it as an “enabling” library. VTU 2 is both a complete library to test out components, and also a baseline to build other tools – We even developed a plugin system. This means that VTU is still a valid choice, and that there's no need to rewrite any codebase from VTU to Vue Testing Library.
During conversarions, we agreed that Vue Testing Library had a terser, useful API and that we should recommend it to newcomers.
Closes #326