Skip to content

Feat/support vue page #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jul 24, 2020

Conversation

marina-mosti
Copy link
Collaborator

@marina-mosti marina-mosti commented Jul 21, 2020

@fatony788
Copy link

ghuh

@NataliaTepluhina
Copy link
Member

@marina-mosti Netlify deployment throws an error ReferenceError: window is not defined

@marina-mosti
Copy link
Collaborator Author

@marina-mosti Netlify deployment throws an error ReferenceError: window is not defined

Thanks @NataliaTepluhina I just noticed, the last commit should fix. Also added a couple missing logos

@marina-mosti marina-mosti force-pushed the feat/support-vue-page branch from ddb46ef to 4845273 Compare July 21, 2020 16:34
@NataliaTepluhina
Copy link
Member

@marina-mosti thank you for taking a huge effort for moving this page! It looks great!

Would you mind also adding a sidebar there and keeping the container max-width: 740px; (I believe it's a default VuePress one). It looks a bit unpolished w/o sidebar:

Screenshot 2020-07-22 at 12 45 39

@marina-mosti
Copy link
Collaborator Author

Hey @NataliaTepluhina, ended up refactoring the whole thing into markdown with a couple components sprinkled in between. Looks neater, and should be easier to maintain.

@NataliaTepluhina
Copy link
Member

@marina-mosti thank you for taking an effort an implementing all the changes 🙇🏻 Looks good to me!

@NataliaTepluhina NataliaTepluhina merged commit 3173219 into vuejs:master Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants