Skip to content

Create a wider container for the codepens #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2020
Merged

Conversation

sdras
Copy link
Member

@sdras sdras commented Jul 18, 2020

Working on the responsive styles for the explainer codepens but I think they will be more legible with a wider container.

Copy link
Member

@bencodezen bencodezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid observation! I think these improvements are worth shipping sooner rather than later.

I'm under the impression you'll submit a separate PR for responsive styling, but don't want to merge in case you didn't want to ship yet.

@sdras
Copy link
Member Author

sdras commented Jul 19, 2020

Yep exactly, otherwise it looks broken in the meantime. Thanks!

@sdras sdras merged commit 0cf9f00 into master Jul 19, 2020
@sdras sdras deleted the reactivity-updates branch July 19, 2020 01:51
TalexDreamSoul pushed a commit to Talexs/docs that referenced this pull request Apr 17, 2022
* review: custom-directives.md

* update

* update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants