Skip to content

Added custom components interop migration section #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 15, 2020

Conversation

NataliaTepluhina
Copy link
Member

  • Added custom components interop migration section
  • Fixed incorrect occurrences for is atribute
  • Added API section for v-is directive

Note: Customized Built-in Elements section doesn't follow our common 2.x/3.x syntax but it was more logical to have the current flow. I'm open to any improvements though! 😅

Close #150

Copy link
Member

@bencodezen bencodezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two minor rephrase suggestions, but thanks for finishing this one! It looks great!


## Autonomous Custom Elements

If we want to add a custom element defined outside of Vue (e.g. using the Web Components API), we need to 'instruct' Vue to treat it as a custom element. Let's use the following template as an example.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If we want to add a custom element defined outside of Vue (e.g. using the Web Components API), we need to 'instruct' Vue to treat it as a custom element. Let's use the following template as an example.
If we want to add a custom element defined outside of Vue (e.g. using the Web Components API), we need to 'instruct' Vue to treat it as a custom element. Let's use the following component as an example.

Is component more accurate?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bencodezen ugh, it's complicated 😅 it's a custom element, not Vue component, that's why I used template word here

@NataliaTepluhina NataliaTepluhina merged commit 77090a7 into master Jul 15, 2020
@NataliaTepluhina NataliaTepluhina deleted the custom-components-interop branch July 17, 2020 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add migration section for custom elements interop improvements
2 participants