Watcher: Error catching fixed #1573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a typo/mistake in the example try-catch block. It should either be `error` in the catch clause or `e` in the statement.
```
try {
.....
} catch (error) {
answer.value = 'Error! Could not reach the API. ' + error
}
```
|
✔️ Deploy Preview for vuejs ready! 🔨 Explore the source changes: 37ec79a 🔍 Inspect the deploy log: https://app.netlify.com/sites/vuejs/deploys/6213be79fdb3a300071ab794 😎 Browse the preview: https://deploy-preview-1573--vuejs.netlify.app |
The playground links are updated to match the code changes.
skirtles-code
suggested changes
Feb 21, 2022
There was a problem hiding this comment.
Thanks for the fix!
There seems to be a problem with the first Playground. The URL has changed to https://yesno.wtf/apdi, with a letter d that shouldn't be there. I assume that's leftover from testing the error handling.
If you could fix that URL I think we can get this merged. Thanks.
Fixed the API URL typo in the options API playground Changes were made from https://yesno.wtf/apdi to https://yesno.wtf/api
|
@skirtles-code Thanks for pointing it out, I have fixed the URL. |
skirtles-code
approved these changes
Feb 21, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Problem
There was a typo/mistake in the example try-catch block.
Proposed Solution
It should either be
errorin the catch clause orein the statement.