Add info about v-bind in CSS under CSSProperties #1518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using SFC its often not necessary to do type augmentation if v-bind in CSS is used.
|
✔️ Deploy Preview for vuejs ready! 🔨 Explore the source changes: 7ff8c24 🔍 Inspect the deploy log: https://app.netlify.com/sites/vuejs/deploys/620679e224f78c00085afc64 😎 Browse the preview: https://deploy-preview-1518--vuejs.netlify.app |
NataliaTepluhina
approved these changes
Feb 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using SFC it's often not necessary to do type augmentation if v-bind in CSS is used.
Description of Problem
Adding custom properties in a template causes a type error because custom properties are not accounted for in
CSSProperties. Searching how to fix that error frequently leads to the docs on CSSProperties and how to augment the type.Proposed Solution
Using
v-bindin CSS is often the better solution or is at least relevant so linking to that documentation will help convey another solution to fixing the type error.