fix: typos inside of public markdown docs #1500
Conversation
|
✔️ Deploy Preview for vuejs ready! 🔨 Explore the source changes: ffbd03f 🔍 Inspect the deploy log: https://app.netlify.com/sites/vuejs/deploys/6201db449a8cb300073cbf52 😎 Browse the preview: https://deploy-preview-1500--vuejs.netlify.app |
There was a problem hiding this comment.
@JessicaSachs thank you for catching so many typos! I've left comments on the cases I disagree with, rest of the fixes look great to me 👍🏻
src/api/component-instance.md
Outdated
| @@ -251,10 +251,10 @@ Imperative API for creating watchers. | |||
| Stopping the watcher: | |||
|
|
|||
| ```js | |||
| const unwatch = this.$watch('a', cb) | |||
| const stopWatching = this.$watch('a', cb) | |||
There was a problem hiding this comment.
question: Could you please provide more context on why this change is necessary?
There was a problem hiding this comment.
Unwatch didn't pass spellcheck. I didn't realize it was even a word. https://en.m.wiktionary.org/wiki/unwatch it's marked as rare because it isn't used often.
stopWatching is much clearer and passes spellcheck.
There was a problem hiding this comment.
I don't feel strongly about it.
I didn't realize we'd get so many typo PRs after launching the website 😅. I don't think any of these are duplicates.
The changes are scoped to the public markdown documents, not code, so there shouldn't be much risk.