Skip to content

Advanced section + Composition API #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jul 12, 2020
Merged

Conversation

NataliaTepluhina
Copy link
Member

This PR restructures the sidebar to move part of the guides to Advanced Techniques (I'm completely open about changing the name if anyone has a better idea 😅

Also, we move detailed explanations from Reactivity API reference and Composition API reference to the guide and we leave only actual reference in the API (params. typings, examples etc.)

Close #126

@NataliaTepluhina NataliaTepluhina added the enhancement New feature or request label Jul 4, 2020
@NataliaTepluhina NataliaTepluhina added this to the alpha milestone Jul 4, 2020
@NataliaTepluhina NataliaTepluhina self-assigned this Jul 4, 2020
]
},
{
title: 'Tooling',
title: 'Advanced Techniques',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe Advanced Guides would be a better generic category? At least at first glance, techniques seems like specific code methods (i.e., composition API) versus something more conceptual like "how reactivity works."

What do you think?

Copy link
Member

@bencodezen bencodezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love what you did with it! And you even incorporated some of the stuff I wrote in Notion already. 💚

Let me know when you're ready to merge and I'll do another review!

@NataliaTepluhina
Copy link
Member Author

@bencodezen yup! Notion guide was super helpful!

Will rename a section 👌

@NataliaTepluhina NataliaTepluhina linked an issue Jul 7, 2020 that may be closed by this pull request
8 tasks
@NataliaTepluhina NataliaTepluhina marked this pull request as ready for review July 9, 2020 17:56
@NataliaTepluhina
Copy link
Member Author

@bencodezen @phanan @sdras I did a refactoring for Advanced section as we've discussed on the Docs meeting. Could you please review the changes? 🙏

Copy link
Member

@bencodezen bencodezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @NataliaTepluhina! So excited for this new section of the docs!

@NataliaTepluhina NataliaTepluhina merged commit b527141 into master Jul 12, 2020
@NataliaTepluhina NataliaTepluhina deleted the advanced-section branch July 15, 2020 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Advanced Section Composition API in-depth guide
2 participants