Skip to content

Teleport component guide + API reference #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 4, 2020
Merged

Teleport component guide + API reference #124

merged 10 commits into from
Jul 4, 2020

Conversation

NataliaTepluhina
Copy link
Member

This addition mostly relies on Teleport RFC

@NataliaTepluhina
Copy link
Member Author

@LinusBorg may I ask for your review in particular as an author of portal-vue and teleport?

@LinusBorg
Copy link
Member

LinusBorg commented Jul 1, 2020

Sure! Will put it at the top of my list.

Copy link
Member

@LinusBorg LinusBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, I left a few suggestions, most of them minor details.

@NataliaTepluhina
Copy link
Member Author

@LinusBorg thank you for such a detailed and well-thought review! 🙇

I've applied all the requested fixes and suggestions, could you please take a second look to ensure I don't miss anything?

@NataliaTepluhina NataliaTepluhina self-assigned this Jul 3, 2020
@NataliaTepluhina NataliaTepluhina added the enhancement New feature or request label Jul 3, 2020
@NataliaTepluhina NataliaTepluhina added this to the alpha milestone Jul 3, 2020
@NataliaTepluhina NataliaTepluhina linked an issue Jul 3, 2020 that may be closed by this pull request
Copy link
Member

@LinusBorg LinusBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin all good now!

@NataliaTepluhina NataliaTepluhina merged commit 3f4a190 into master Jul 4, 2020
@NataliaTepluhina NataliaTepluhina deleted the teleport branch July 15, 2020 09:15
TalexDreamSoul pushed a commit to Talexs/docs that referenced this pull request Apr 17, 2022
* fix: build error beacuse of lack VueSchoolLink component

* refactor: update index.md and add some components
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation on <Teleport> component
2 participants