-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Teleport component guide + API reference #124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@LinusBorg may I ask for your review in particular as an author of |
Sure! Will put it at the top of my list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, I left a few suggestions, most of them minor details.
Co-authored-by: Thorsten Lünborg <[email protected]>
Co-authored-by: Thorsten Lünborg <[email protected]>
Co-authored-by: Thorsten Lünborg <[email protected]>
Co-authored-by: Thorsten Lünborg <[email protected]>
Co-authored-by: Thorsten Lünborg <[email protected]>
Co-authored-by: Thorsten Lünborg <[email protected]>
@LinusBorg thank you for such a detailed and well-thought review! 🙇 I've applied all the requested fixes and suggestions, could you please take a second look to ensure I don't miss anything? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lookin all good now!
* fix: build error beacuse of lack VueSchoolLink component * refactor: update index.md and add some components
This addition mostly relies on Teleport RFC