Skip to content

Migrate: Single page components #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 18, 2020
Merged

Migrate: Single page components #118

merged 4 commits into from
Jun 18, 2020

Conversation

phanan
Copy link
Member

@phanan phanan commented Jun 14, 2020

Migrate the Single Page Components page. I had to use CodeSandBox for some of the samples/demos due CodePen's limitations.

Preview available at https://deploy-preview-118--vue-docs-next-preview.netlify.app/guide/single-file-component.html#introduction.

Copy link
Member

@NataliaTepluhina NataliaTepluhina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phanan Looks great! I've left a minor comment regarding VueSchool link, rest looks good to me 👍

@bencodezen bencodezen mentioned this pull request Jun 14, 2020
5 tasks
@phanan phanan self-assigned this Jun 14, 2020
@phanan phanan added the content Issues / PRs related to docs content label Jun 14, 2020
@phanan phanan added this to the alpha milestone Jun 14, 2020
@phanan phanan requested a review from znck June 15, 2020 07:16
@phanan phanan merged commit cf0d61f into master Jun 18, 2020
@phanan phanan deleted the migration/tooling/sfc branch June 18, 2020 10:12
TalexDreamSoul pushed a commit to Talexs/docs that referenced this pull request Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Issues / PRs related to docs content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants