Skip to content

Move Non-props attributes to the separate section in docs #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NataliaTepluhina opened this issue Jul 3, 2020 · 1 comment · Fixed by #340
Closed

Move Non-props attributes to the separate section in docs #130

NataliaTepluhina opened this issue Jul 3, 2020 · 1 comment · Fixed by #340
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@NataliaTepluhina
Copy link
Member

Currently, $attrs are explaine within Component props section and I believe it's not that obvious and makes it harder to find guide on attributes fallthrough. I propose to move it to the separate page (maybe also extend it with some examples)

@NataliaTepluhina NataliaTepluhina added the enhancement New feature or request label Jul 3, 2020
@NataliaTepluhina NataliaTepluhina added this to the release milestone Jul 3, 2020
@NataliaTepluhina NataliaTepluhina self-assigned this Jul 3, 2020
@bencodezen
Copy link
Member

bencodezen commented Jul 9, 2020

We also need to update this section with what's going on in this RFC:

https://github.com/vuejs/rfcs/blob/master/active-rfcs/0031-attr-fallthrough.md

I encountered some gotchas in documenting something else where we need to explain how listeners are now a part of attrs.

Let me know if you need help or have questions!

@NataliaTepluhina NataliaTepluhina linked a pull request Jul 25, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants