update role allowances for button and input type=button #1301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds `role=combobox` as an allowed role for `button` and `input type=button`. adds `role=checkbox` as an allowed role for `input type=button` to match the `button` element allowances.
4 tasks
sideshowbarker
approved these changes
Jan 21, 2022
This was referenced Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARIA in HTML is planning to allow
role=comboboxon abuttonandinput type=buttonelement. This PR updates the validator to allow this role on these elements.Adds
role=comboboxas an allowed role forbuttonandinput type=button.Additionally, this PR adds
role=checkboxas an allowed role forinput type=buttonto match thebuttonelement allowances. This was an oversight in the spec which this PR will help correct.