-
Notifications
You must be signed in to change notification settings - Fork 25
Added perception module #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @bitcurious, thanks a lot for your contribution! That is an awesome piece of work. We will take a look into the code in the upcoming days. In the meantime, if you could fix the linter issues it would be really helpful. You can autoformat based on .clang-format
file and CPPLINT.cfg
located at the root of the repository.
@vicmassy Sure I have solved many of them only 88 character per line exceeeding those are remaining will solve them using autoformat as you mentioned. |
@vicmassy I have fixed all linter issues please look inti it once you get the time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bitcurious very nice development and a great contribution having this new module on the wrapper! 🎊 I left you some comments and some improvements that can be done. Let me know what you think !
246f57f
to
f177c65
Compare
@biancabnd I have addressed all the comments you raised. Apologies for the multiple commits; I encountered some issues with my GitHub account in VS Code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RTBM! 🎊
Basic Info
Description of contribution in a few bullet points
Motivation and Context
How Has This Been Tested?
Description of documentation updates required from your changes
I have updated the
docs/documentation/ThePSDKWrapper.md
file with my changed please add the same chnages on psdk_ros2 wrapper wiki.Future work that may be required in bullet points
Screenshots (if appropriate):