Skip to content

Added perception module #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 9, 2024
Merged

Added perception module #110

merged 7 commits into from
Jul 9, 2024

Conversation

bitcurious
Copy link
Contributor


Basic Info

Info Please fill out this column
Ticket(s) this addresses #97
Primary OS tested on Ubuntu
Drone platform tested on M300

Description of contribution in a few bullet points

  1. Added perception module.
  2. Now one can able to subscribe stereo vision camera stream using this module.
  3. Camera parameters for respective stereo cameras is also available.

Motivation and Context

  1. Perception was a major module provided by th DJI PSDK but it was not integrated in this wrapper.
  2. Stereo / Perperction camera help to perform visual simultaneous localization and mapping (vSLAM).
  3. Stereo cameras provide single shot 3D reconstructions of the imaged scene by using perspective changes in two camera views.

How Has This Been Tested?

  1. Tested on M300 Drone using OSDK extension module.
  2. I tested stereo camera stream and parameteres for respective direction.
  3. Start and stop of stream is also tested.
  4. Perception module doesn't affect any pre-existed

Description of documentation updates required from your changes

I have updated the docs/documentation/ThePSDKWrapper.md file with my changed please add the same chnages on psdk_ros2 wrapper wiki.

Future work that may be required in bullet points

Screenshots (if appropriate):

@bitcurious bitcurious requested a review from a team as a code owner June 11, 2024 11:50
Copy link

@vicmassy vicmassy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bitcurious, thanks a lot for your contribution! That is an awesome piece of work. We will take a look into the code in the upcoming days. In the meantime, if you could fix the linter issues it would be really helpful. You can autoformat based on .clang-format file and CPPLINT.cfg located at the root of the repository.

@umesh-mane
Copy link

@vicmassy Sure I have solved many of them only 88 character per line exceeeding those are remaining will solve them using autoformat as you mentioned.

@umesh-mane
Copy link

@vicmassy I have fixed all linter issues please look inti it once you get the time.

Copy link
Contributor

@biancabnd biancabnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bitcurious very nice development and a great contribution having this new module on the wrapper! 🎊 I left you some comments and some improvements that can be done. Let me know what you think !

@bitcurious bitcurious force-pushed the perception branch 2 times, most recently from 246f57f to f177c65 Compare July 4, 2024 09:30
@bitcurious
Copy link
Contributor Author

@biancabnd I have addressed all the comments you raised. Apologies for the multiple commits; I encountered some issues with my GitHub account in VS Code.

@vicmassy vicmassy requested a review from biancabnd July 4, 2024 13:40
Copy link
Contributor

@biancabnd biancabnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RTBM! 🎊

@biancabnd biancabnd merged commit 5f0c212 into umdlife:main Jul 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants