-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Launcher sets default upgrader policy #213
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy
in the new code
clang-format
found formatting issues in the code submitted.:warning:
Make sure to run clang-format and update this pull request.
(1/1)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy
in the new code
clang-format
found formatting issues in the code submitted.:warning:
Make sure to run clang-format and update this pull request.
(1/1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy
in the new code
clang-format
found formatting issues in the code submitted.:warning:
Make sure to run clang-format and update this pull request.
(1/2)
DistroLauncher/Patches.cpp
Outdated
bool ShutdownDistro() | ||
{ | ||
const std::wstring shutdownCmd = L"wsl -t " + DistributionInfo::Name; | ||
if (int cmdResult = _wsystem(shutdownCmd.c_str()); cmdResult != 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
redundant boolean literal in conditional return statement
if (int cmdResult = _wsystem(shutdownCmd.c_str()); cmdResult != 0) { | |
return cmdResult == 0; |
Closing in favour of refactored #226 |
This pull request depends on #217
Ubuntu desktop proposes upgrades according to a certain policy:
There are different releases of Ubuntu WSL on the Microsoft store. These can be classified in three categories. Currently, the policy is always
lts
by default. This PR changes the default upgrader policy to:Ubuntu 20.04.4 LTS
Ubuntu 22.04 LTS