fix(eslint-plugin): [no-unsafe-enum-comparison] add logic to see through intersections

[Zamiell]

PR Checklist

• Addresses an existing open issue: fixes Bug: [no-unsafe-enum-comparison] false positive with enums in a union with branded types #7114
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

Added additional logic for the rule to "see through" intersections, allowing the rule to work properly in the case outlined in the linked issue.

[typescript-eslint]

Thanks for the PR, @Zamiell!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	fa0edf3
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/66ba45ce0681800008161122
😎 Deploy Preview	https://deploy-preview-9777--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 97 (🔴 down 3 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 90 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit fa0edf3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 2 targets

• nx run-many --target=build --exclude website --exclude website-eslint
• nx run-many --target=clean

---

Sent with 💌 from NxCloud.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.93%. Comparing base (278697f) to head (fa0edf3).
Report is 40 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9777      +/-   ##
==========================================
- Coverage   87.93%   87.93%   -0.01%     
==========================================
  Files         402      403       +1     
  Lines       13722    13802      +80     
  Branches     3996     4022      +26     
==========================================
+ Hits        12067    12137      +70     
- Misses       1350     1358       +8     
- Partials      305      307       +2     

Flag	Coverage Δ
unittest	87.93% <100.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...lint-plugin/src/rules/no-unsafe-enum-comparison.ts	100.00% <100.00%> (ø)

... and 9 files with indirect coverage changes

[Zamiell]

The CI failure looks unrelated to my PR:

Linting "integration-tests"...

 NX   _


AtomicsWaitError: _
    at _Lock.lock (/home/runner/work/typescript-eslint/typescript-eslint/node_modules/make-synchronized/index.cjs:128:11)
    at request (/home/runner/work/typescript-eslint/typescript-eslint/node_modules/make-synchronized/index.cjs:161:8)
    at #sendActionToWorker (/home/runner/work/typescript-eslint/typescript-eslint/node_modules/make-synchronized/index.cjs:218:61)
    at ThreadsWorker.sendAction (/home/runner/work/typescript-eslint/typescript-eslint/node_modules/make-synchronized/index.cjs:177:36)
    at /home/runner/work/typescript-eslint/typescript-eslint/node_modules/make-synchronized/index.cjs:273:26
    at cacheResult (/home/runner/work/typescript-eslint/typescript-eslint/node_modules/make-synchronized/index.cjs:242:25)
    at cachePathResult (/home/runner/work/typescript-eslint/typescript-eslint/node_modules/make-synchronized/index.cjs:246:52)
    at _Synchronizer.getInformation (/home/runner/work/typescript-eslint/typescript-eslint/node_modules/make-synchronized/index.cjs:270:12)
    at _Synchronizer.get (/home/runner/work/typescript-eslint/typescript-eslint/node_modules/make-synchronized/index.cjs:277:30)
    at Module.get [as resolveConfig] (/home/runner/work/typescript-eslint/typescript-eslint/node_modules/make-synchronized/index.cjs:350:29)

Maybe something is wrong with NX?

[JoshuaKGoldberg]

Yeah, AtomicsWaitError has been happening once in a while... cc @JamesHenry, I see it a few times a month 😞

[JoshuaKGoldberg]

This is looking nice and clean! Just requesting changes on tests 🚀

[JoshuaKGoldberg]

🔥 this is lovely, thanks @Zamiell!