fix(eslint-plugin): [no-unnecessary-condition] false positive on optional private field

[StyleShit]

PR Checklist

• Addresses an existing open issue: fixes Bug: [no-unnecessary-condition] false positive on optional private field #9564
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

This PR accounts for private identifiers when checking if a member expression is nullable

Not sure if/which additional test cases I should add here, so I'm open for suggestions 😄

[typescript-eslint]

Thanks for the PR, @StyleShit!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	ef7539f
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/669d480b68b5d900087badac
😎 Deploy Preview	https://deploy-preview-9602--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 96 (🟢 up 2 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 90 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ef7539f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 1 target

• nx run repo-tools:postinstall-script

---

Sent with 💌 from NxCloud.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.45%. Comparing base (863eb86) to head (ef7539f).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #9602   +/-   ##
=======================================
  Coverage   88.45%   88.45%           
=======================================
  Files         422      422           
  Lines       14694    14695    +1     
  Branches     4299     4298    -1     
=======================================
+ Hits        12997    12998    +1     
  Misses       1372     1372           
  Partials      325      325           

Flag	Coverage Δ
unittest	88.45% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...slint-plugin/src/rules/no-unnecessary-condition.ts	98.57% <100.00%> (+<0.01%)	⬆️

[StyleShit]

This condition is unnecessary because the property type is Identifier | PrivateIdentifier,
and now we catch both of them

[kirkwaiblinger]

Looks good to me! Nice 🙂