Skip to content

fix(typescript-estree): don't infer single-run when --fix is in proces.argv #9577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Jul 18, 2024

PR Checklist

Overview

Does a straightforward check for '--fix' in process.argv.

I'd have loved to use something more ... not-hacky, i.e. some explicit indication from ESLint itself. But our old friend eslint/rfcs#102 was rejected.

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Jul 18, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit ddcf7e2
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66988fd7c158a700086b0e63
😎 Deploy Preview https://deploy-preview-9577--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 94 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@JoshuaKGoldberg JoshuaKGoldberg added this to the 8.0.0 milestone Jul 18, 2024
Copy link

nx-cloud bot commented Jul 18, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ddcf7e2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.38%. Comparing base (90bacee) to head (ddcf7e2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9577   +/-   ##
=======================================
  Coverage   88.38%   88.38%           
=======================================
  Files         419      419           
  Lines       14620    14620           
  Branches     4279     4279           
=======================================
  Hits        12922    12922           
  Misses       1374     1374           
  Partials      324      324           
Flag Coverage Δ
unittest 88.38% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...escript-estree/src/parseSettings/inferSingleRun.ts 93.75% <100.00%> (ø)

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as a temporary workaround.

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jul 18, 2024
@JoshuaKGoldberg JoshuaKGoldberg merged commit 7528aba into typescript-eslint:main Jul 18, 2024
70 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the infer-single-run-fix branch July 18, 2024 16:33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants