-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix(typescript-estree): don't infer single-run when --fix is in proces.argv #9577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(typescript-estree): don't infer single-run when --fix is in proces.argv #9577
Conversation
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit ddcf7e2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9577 +/- ##
=======================================
Coverage 88.38% 88.38%
=======================================
Files 419 419
Lines 14620 14620
Branches 4279 4279
=======================================
Hits 12922 12922
Misses 1374 1374
Partials 324 324
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved as a temporary workaround.
PR Checklist
Overview
Does a straightforward check for
'--fix'
inprocess.argv
.I'd have loved to use something more ... not-hacky, i.e. some explicit indication from ESLint itself. But our old friend eslint/rfcs#102 was rejected.
💖