-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix(eslint-plugin): remove duplicate import RuleModuleWithMetaDocs
#9465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eslint-plugin): remove duplicate import RuleModuleWithMetaDocs
#9465
Conversation
Thanks for the PR, @abrahamguo! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. Thanks for the catch!
...on or off? I would be +1 on a followup issue around some kind of end-to-end / integration test to catch these errors, for sure. Good call! |
oh yes haha, I did mean "turn skipLibCheck off". |
…eslint into duplicate-identifier
PR Checklist
Overview
In #9339, @JoshuaKGoldberg introduced a regression causing a duplicate import identifier. In a project that consumes
@typescript-eslint/[email protected]
, this causes two TypeScript errors in that file (ifskipLibCheck
isfalse
), complaining about the duplicate import.I'm not sure, by the way, why this is not a TS error in the repo itself, but causes a TS error when in the
node_modules
of another package.Should we consider turning on
skipLibCheck
in this repo?Also, I did a cursory search and was unable to find any rule in
eslint
,typescript-eslint
oreslint-plugin-import
that would allow us to catch issues like these 🙁