Skip to content

fix(eslint-plugin): remove duplicate import RuleModuleWithMetaDocs #9465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

abrahamguo
Copy link
Contributor

@abrahamguo abrahamguo commented Jul 1, 2024

PR Checklist

Overview

In #9339, @JoshuaKGoldberg introduced a regression causing a duplicate import identifier. In a project that consumes @typescript-eslint/[email protected], this causes two TypeScript errors in that file (if skipLibCheck is false), complaining about the duplicate import.

I'm not sure, by the way, why this is not a TS error in the repo itself, but causes a TS error when in the node_modules of another package.
Should we consider turning on skipLibCheck in this repo?
Also, I did a cursory search and was unable to find any rule in eslint, typescript-eslint or eslint-plugin-import that would allow us to catch issues like these 🙁

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @abrahamguo!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Jul 1, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit ae2bb65
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6682a0f9b0454e00085328d8
😎 Deploy Preview https://deploy-preview-9465--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 97 (🔴 down 3 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Thanks for the catch!

@JoshuaKGoldberg
Copy link
Member

Should we consider turning on skipLibCheck in this repo?

...on or off?

I would be +1 on a followup issue around some kind of end-to-end / integration test to catch these errors, for sure. Good call!

@abrahamguo
Copy link
Contributor Author

oh yes haha, I did mean "turn skipLibCheck off".

Copy link

nx-cloud bot commented Jul 1, 2024

@JoshuaKGoldberg JoshuaKGoldberg merged commit 9dce771 into typescript-eslint:v8 Jul 1, 2024
62 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants