Skip to content

fix(types): correct typing ParserOptions #9202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 1, 2024
Merged

fix(types): correct typing ParserOptions #9202

merged 2 commits into from
Jun 1, 2024

Conversation

nix6839
Copy link
Contributor

@nix6839 nix6839 commented Jun 1, 2024

PR Checklist

Overview

I updated the type and refactored the code to prevent the same situation from happening again.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @nix6839!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Jun 1, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit f94aa69
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/665b652d9dc7060008164a72
😎 Deploy Preview https://deploy-preview-9202--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (🟢 up 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented Jun 1, 2024

Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Love sugaring up from an Object.assign to a .... Thanks! 🙌

Ryan Reynolds sincerely nodding and saying "MUCH BETTER"

@JoshuaKGoldberg JoshuaKGoldberg merged commit 2bbf656 into typescript-eslint:main Jun 1, 2024
61 checks passed
@nix6839 nix6839 deleted the fix-type branch June 1, 2024 20:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: incompatible type ParserOptions['projectFolderIgnoreList']
3 participants