Skip to content

fix(eslint-plugin): [no-dynamic-delete] prevent fixing to identifiers #1244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

a-tarasyuk
Copy link
Contributor

Fixing #1240

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @a-tarasyuk!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Nov 20, 2019

Codecov Report

Merging #1244 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1244      +/-   ##
==========================================
- Coverage   94.23%   94.23%   -0.01%     
==========================================
  Files         126      126              
  Lines        5379     5377       -2     
  Branches     1511     1510       -1     
==========================================
- Hits         5069     5067       -2     
  Misses        177      177              
  Partials      133      133
Impacted Files Coverage Δ
...kages/eslint-plugin/src/rules/no-dynamic-delete.ts 100% <100%> (ø) ⬆️

@bradzacher bradzacher changed the title fix(eslint-plugin): prevent fixing to identifiers fix(eslint-plugin): [no-dynamic-delete] prevent fixing to identifiers Nov 20, 2019
@bradzacher bradzacher added the bug Something isn't working label Nov 20, 2019
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants