Merge branch 'main' into fix-token-type-of-property-name

Author: ntdiary

CHANGELOG.md

@@ -1,3 +1,20 @@
+## 8.35.0 (2025-06-23)
+
+### 🚀 Features
+
+- **eslint-plugin:** [no-base-to-string] add checkUnknown Option ([#11128](https://github.com/typescript-eslint/typescript-eslint/pull/11128))
+
+### 🩹 Fixes
+
+- **website:** acquired types are shown in the editor but not reflected in linting ([#11198](https://github.com/typescript-eslint/typescript-eslint/pull/11198))
+
+### ❤️ Thank You
+
+- Kim Sang Du @developer-bandi
+- mdm317
+
+You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.
+
 ## 8.34.1 (2025-06-16)
 
 ### 🩹 Fixes

docs/getting-started/Typed_Linting.mdx

@@ -40,11 +40,6 @@ export default tseslint.config(
 );
 ```
 
-:::note
-[`import.meta.dirname`](https://nodejs.org/api/esm.html#importmetadirname) is only present for ESM files in Node.js >=20.11.0 / >= 21.2.0.<br />
-For CommonJS modules and/or older versions of Node.js, [use `__dirname` or an alternative](https://stackoverflow.com/questions/46745014/alternative-for-dirname-in-node-js-when-using-es6-modules).
-:::
-
 In more detail:
 
 - `tseslint.configs.recommendedTypeChecked` is a [shared configuration](../users/Shared_Configurations.mdx). It contains recommended rules that additionally require type information.

packages/ast-spec/CHANGELOG.md

@@ -1,3 +1,9 @@
+## 8.35.0 (2025-06-23)
+
+This was a version bump only for ast-spec to align it with other projects, there were no code changes.
+
+You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.
+
 ## 8.34.1 (2025-06-16)
 
 ### 🩹 Fixes

packages/ast-spec/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@typescript-eslint/ast-spec",
-  "version": "8.34.1",
+  "version": "8.35.0",
   "description": "Complete specification for the TypeScript-ESTree AST",
   "private": true,
   "keywords": [

packages/eslint-plugin/CHANGELOG.md

@@ -1,3 +1,15 @@
+## 8.35.0 (2025-06-23)
+
+### 🚀 Features
+
+- **eslint-plugin:** [no-base-to-string] add checkUnknown Option ([#11128](https://github.com/typescript-eslint/typescript-eslint/pull/11128))
+
+### ❤️ Thank You
+
+- Kim Sang Du @developer-bandi
+
+You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.
+
 ## 8.34.1 (2025-06-16)
 
 This was a version bump only for eslint-plugin to align it with other projects, there were no code changes.

packages/eslint-plugin/docs/rules/no-base-to-string.mdx

@@ -99,6 +99,17 @@ let text = `${value}`;
 String(/regex/);
 ```
 
+### `checkUnknown`
+
+{/* insert option description */}
+
+The following patterns are considered incorrect with the options `{ checkUnknown: true }`:
+
+```ts option='{ "checkUnknown": true }' showPlaygroundButton
+declare const x: unknown;
+String(x);
+```
+
 ## When Not To Use It
 
 If you don't mind a risk of `"[object Object]"` or incorrect type coercions in your values, then you will not need this rule.

packages/eslint-plugin/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@typescript-eslint/eslint-plugin",
-  "version": "8.34.1",
+  "version": "8.35.0",
   "description": "TypeScript plugin for ESLint",
   "files": [
     "dist",
@@ -60,10 +60,10 @@
   },
   "dependencies": {
     "@eslint-community/regexpp": "^4.10.0",
-    "@typescript-eslint/scope-manager": "8.34.1",
-    "@typescript-eslint/type-utils": "8.34.1",
-    "@typescript-eslint/utils": "8.34.1",
-    "@typescript-eslint/visitor-keys": "8.34.1",
+    "@typescript-eslint/scope-manager": "8.35.0",
+    "@typescript-eslint/type-utils": "8.35.0",
+    "@typescript-eslint/utils": "8.35.0",
+    "@typescript-eslint/visitor-keys": "8.35.0",
     "graphemer": "^1.4.0",
     "ignore": "^7.0.0",
     "natural-compare": "^1.4.0",
@@ -72,8 +72,8 @@
   "devDependencies": {
     "@types/mdast": "^4.0.3",
     "@types/natural-compare": "*",
-    "@typescript-eslint/rule-schema-to-typescript-types": "8.34.1",
-    "@typescript-eslint/rule-tester": "8.34.1",
+    "@typescript-eslint/rule-schema-to-typescript-types": "8.35.0",
+    "@typescript-eslint/rule-tester": "8.35.0",
     "@vitest/coverage-v8": "^3.1.3",
     "ajv": "^6.12.6",
     "cross-fetch": "*",
@@ -93,7 +93,7 @@
     "vitest": "^3.1.3"
   },
   "peerDependencies": {
-    "@typescript-eslint/parser": "^8.34.1",
+    "@typescript-eslint/parser": "^8.35.0",
     "eslint": "^8.57.0 || ^9.0.0",
     "typescript": ">=4.8.4 <5.9.0"
   },

packages/eslint-plugin/src/rules/no-base-to-string.ts

@@ -21,6 +21,7 @@ enum Usefulness {
 export type Options = [
   {
     ignoredTypeNames?: string[];
+    checkUnknown?: boolean;
   },
 ];
 export type MessageIds = 'baseArrayJoin' | 'baseToString';
@@ -46,6 +47,10 @@ export default createRule<Options, MessageIds>({
         type: 'object',
         additionalProperties: false,
         properties: {
+          checkUnknown: {
+            type: 'boolean',
+            description: 'Whether to also check values of type `unknown`',
+          },
           ignoredTypeNames: {
             type: 'array',
             description:
@@ -60,6 +65,7 @@ export default createRule<Options, MessageIds>({
   },
   defaultOptions: [
     {
+      checkUnknown: false,
       ignoredTypeNames: ['Error', 'RegExp', 'URL', 'URLSearchParams'],
     },
   ],
@@ -76,6 +82,7 @@ export default createRule<Options, MessageIds>({
         type ?? services.getTypeAtLocation(node),
         new Set(),
       );
+
       if (certainty === Usefulness.Always) {
         return;
       }
@@ -213,7 +220,7 @@ export default createRule<Options, MessageIds>({
           return collectToStringCertainty(constraint, visited);
         }
         // unconstrained generic means `unknown`
-        return Usefulness.Always;
+        return option.checkUnknown ? Usefulness.Sometimes : Usefulness.Always;
       }
 
       // the Boolean type definition missing toString()
@@ -251,8 +258,13 @@ export default createRule<Options, MessageIds>({
       const toString =
         checker.getPropertyOfType(type, 'toString') ??
         checker.getPropertyOfType(type, 'toLocaleString');
+
       if (!toString) {
-        // e.g. any/unknown
+        // unknown
+        if (option.checkUnknown && type.flags === ts.TypeFlags.Unknown) {
+          return Usefulness.Sometimes;
+        }
+        // e.g. any
         return Usefulness.Always;
       }
 

packages/eslint-plugin/tests/docs-eslint-output-snapshots/no-base-to-string.shot

@@ -2,50 +2,6 @@ import { RuleTester } from '@typescript-eslint/rule-tester';
 
 import rule from '../../src/rules/ban-tslint-comment';
 
-interface Testable {
-  code: string;
-  column?: number;
-  line?: number;
-  output?: string;
-  text?: string;
-}
-
-const PALANTIR_EXAMPLES: Testable[] = [
-  { code: '/* tslint:disable */' }, // Disable all rules for the rest of the file
-  { code: '/* tslint:enable */' }, // Enable all rules for the rest of the file
-  {
-    code: '/* tslint:disable:rule1 rule2 rule3... */',
-  }, // Disable the listed rules for the rest of the file
-  {
-    code: '/* tslint:enable:rule1 rule2 rule3... */',
-  }, // Enable the listed rules for the rest of the file
-  { code: '// tslint:disable-next-line' }, // Disables all rules for the following line
-  {
-    code: 'someCode(); // tslint:disable-line',
-    column: 13,
-    output: 'someCode();',
-    text: '// tslint:disable-line',
-  }, // Disables all rules for the current line
-  {
-    code: '// tslint:disable-next-line:rule1 rule2 rule3...',
-  }, // Disables the listed rules for the next line
-];
-
-// prettier-ignore
-const MORE_EXAMPLES: Testable[] = [
-  {
-    code: `const woah = doSomeStuff();
-// tslint:disable-line
-console.log(woah);
-`,
-    line: 2,
-    output: `const woah = doSomeStuff();
-console.log(woah);
-`,
-    text: '// tslint:disable-line',
-  },
-]
-
 const ruleTester = new RuleTester();
 
 ruleTester.run('ban-tslint-comment', rule, {
@@ -66,18 +22,123 @@ ruleTester.run('ban-tslint-comment', rule, {
       code: '/* another comment that mentions tslint */',
     },
   ],
-  invalid: [...PALANTIR_EXAMPLES, ...MORE_EXAMPLES].map(
-    ({ code, column, line, output, text }) => ({
-      code,
+  invalid: [
+    {
+      code: '/* tslint:disable */',
+      errors: [
+        {
+          column: 1,
+          data: {
+            text: '/* tslint:disable */',
+          },
+          line: 1,
+          messageId: 'commentDetected',
+        },
+      ],
+      output: '',
+    },
+    {
+      code: '/* tslint:enable */',
+      errors: [
+        {
+          column: 1,
+          data: {
+            text: '/* tslint:enable */',
+          },
+          line: 1,
+          messageId: 'commentDetected',
+        },
+      ],
+      output: '',
+    },
+    {
+      code: '/* tslint:disable:rule1 rule2 rule3... */',
+      errors: [
+        {
+          column: 1,
+          data: {
+            text: '/* tslint:disable:rule1 rule2 rule3... */',
+          },
+          line: 1,
+          messageId: 'commentDetected',
+        },
+      ],
+      output: '',
+    },
+    {
+      code: '/* tslint:enable:rule1 rule2 rule3... */',
+      errors: [
+        {
+          column: 1,
+          data: {
+            text: '/* tslint:enable:rule1 rule2 rule3... */',
+          },
+          line: 1,
+          messageId: 'commentDetected',
+        },
+      ],
+      output: '',
+    },
+    {
+      code: '// tslint:disable-next-line',
+      errors: [
+        {
+          column: 1,
+          data: {
+            text: '// tslint:disable-next-line',
+          },
+          line: 1,
+          messageId: 'commentDetected',
+        },
+      ],
+      output: '',
+    },
+    {
+      code: 'someCode(); // tslint:disable-line',
       errors: [
         {
-          column: column ?? 1,
-          data: { text: text ?? code },
-          line: line ?? 1,
-          messageId: 'commentDetected' as const,
+          column: 13,
+          data: {
+            text: '// tslint:disable-line',
+          },
+          line: 1,
+          messageId: 'commentDetected',
         },
       ],
-      output: output ?? '',
-    }),
-  ),
+      output: 'someCode();',
+    },
+    {
+      code: '// tslint:disable-next-line:rule1 rule2 rule3...',
+      errors: [
+        {
+          column: 1,
+          data: { text: '// tslint:disable-next-line:rule1 rule2 rule3...' },
+          line: 1,
+          messageId: 'commentDetected',
+        },
+      ],
+      output: '',
+    },
+    {
+      code: `
+const woah = doSomeStuff();
+// tslint:disable-line
+console.log(woah);
+      `,
+      errors: [
+        {
+          column: 1,
+          data: {
+            text: '// tslint:disable-line',
+          },
+          line: 3,
+          messageId: 'commentDetected',
+        },
+      ],
+      output: `
+const woah = doSomeStuff();
+console.log(woah);
+      `,
+    },
+  ],
 });